Skip to content

Beta backport: null terminate UNICODE_STRINGs #143275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

Beta backport: null terminate UNICODE_STRINGs #143275

wants to merge 1 commit into from
+7 −2

Conversation

ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Jul 1, 2025 •
edited
Loading

This is a beta backport of #143090 but, unlike that PR, it only does the minimum necessary. I think it would also be good to backport to stable but only if there's a stable release for another reason.

This will need a t-libs decision.

@ChrisDenton ChrisDenton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 1, 2025
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-android Operating system: Android O-linux Operating system: Linux O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 1, 2025
@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2025
@ChrisDenton ChrisDenton changed the base branch from master to beta July 1, 2025 10:03
@ChrisDenton
Copy link
Member Author

wait, I targeted the wrong branch... oops

@ChrisDenton ChrisDenton removed A-testsuite Area: The testsuite used to check the correctness of rustc O-linux Operating system: Linux O-android Operating system: Android T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. labels Jul 1, 2025
@Urgau Urgau mentioned this pull request Jul 1, 2025
Merged
Amanieu
Amanieu reviewed Jul 2, 2025
View reviewed changes
library/std/src/sys/fs/windows/remove_dir_all.rs
@@ -90,7 +90,11 @@ fn open_link_no_reparse(
static ATTRIBUTES: Atomic<u32> = AtomicU32::new(c::OBJ_DONT_REPARSE);

let result = unsafe {
static EMPTY_STR: [u16; 1] = [0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a comment explaining why this is necessary.

@Amanieu Amanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees

@Amanieu Amanieu

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisDenton @rustbot @Amanieu