Skip to content

Feed explicit_predicates_of instead of predicates_of #143261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

compiler-errors
Copy link
Member

Tiny nitpick, just avoiding needing to mark the predicates_of query as feedable since it's derived from explicit_predicates_of.

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2025

r? @matthewjasper

rustbot has assigned @matthewjasper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member Author

spurious network error lol

@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added the A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) label Jul 1, 2025
@compiler-errors
Copy link
Member Author

compiler-errors commented Jul 1, 2025

Hey @fmease, I ended up removing the doc comments from TyCtxtFeed semi-because of your work in #134787, and so removing TyCtxtFeed::predicates_of breaks the doc comments on TyCtxtFeed::explicit_predicates_of.

Specifically:

Indeed, such links are generally a bit brittle due to the existence of TyCtxtFeed which only contains a subset of queries. Therefore the docs of feedable queries cannot cross-link to non-feedable ones. I'd say it's fine to use intra-doc links despite the potential/unlikely occasional future breakage (if a query with the aforementioned characteristics becomes feedable)

I think TyCtxtFeed is so rare that it's fine to just... straight up ignore doc comments on these methods :) If you've got an alternative suggestion, I'm happy to implement it instead.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 1, 2025

r? @oli-obk

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 1, 2025

📌 Commit ef4f719 has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned matthewjasper Jul 1, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants