Suggest use another lifetime specifier instead of underscore lifetime by xizheyin · Pull Request #143231 · rust-lang/rust

xizheyin · 2025-06-30T09:15:49Z

cc #143152

r? compiler

tests/ui/underscore-lifetime/in-binder.stderr

compiler/rustc_resolve/src/late.rs

tests/ui/lifetimes/lifetime-errors/raw-annomy-lifetime-issue-143152.rs

xizheyin · 2025-07-01T06:57:43Z

@rustbot ready

fee1-dead

please squash the commits

tests/ui/underscore-lifetime/raw-annomy-lifetime-issue-143152.rs

fee1-dead · 2025-07-01T09:46:20Z

tests/ui/underscore-lifetime/raw-annomy-lifetime-issue-143152.rs

+//~^ ERROR `_` cannot be a raw lifetime
+//~| ERROR `'_` cannot be used here [E0637]


you haven't fixed the issue. please deduplicate the diagnostics

For both errors, I think they should be preserved.

Since the first one is for the error of using raw strings, and the second one is the error of not supposed to have underscore in the argument list. I've added a note to the second one to show that they are different.

Then this doesn't fix #143152. If you don't want to fix #143152, we can remove the "Fixes" clause in your PR and merge it.

Ok, I changed Fixes to cc.

You should probably remove this test since it isn't testing any fixes.

Yes, because the problem pointed out in #143152 is not an error, it doesn't need to be fixed.

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

fee1-dead · 2025-07-02T04:15:11Z

@bors r+ rollup

bors · 2025-07-02T04:15:14Z

📌 Commit e7c3703 has been approved by fee1-dead

It is now in the queue for this repository.

Suggest use another lifetime specifier instead of underscore lifetime cc rust-lang#143152 r? compiler

Rollup of 12 pull requests Successful merges: - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions) - #142138 (Add `Vec::into_chunks`) - #142321 (Expose elf abi on ppc64 targets) - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`) - #143038 (avoid suggesting traits from private dependencies) - #143194 (fix bitcast of single-element SIMD vectors) - #143206 (Align attr fixes) - #143231 (Suggest use another lifetime specifier instead of underscore lifetime) - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest) - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition) - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic) - #143274 (ci: support optional jobs) r? `@ghost` `@rustbot` modify labels: rollup

Suggest use another lifetime specifier instead of underscore lifetime cc rust-lang#143152 r? compiler

Rollup of 11 pull requests Successful merges: - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions) - #142138 (Add `Vec::into_chunks`) - #142321 (Expose elf abi on ppc64 targets) - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`) - #143038 (avoid suggesting traits from private dependencies) - #143194 (fix bitcast of single-element SIMD vectors) - #143231 (Suggest use another lifetime specifier instead of underscore lifetime) - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest) - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition) - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic) - #143274 (ci: support optional jobs) r? `@ghost` `@rustbot` modify labels: rollup

Suggest use another lifetime specifier instead of underscore lifetime cc rust-lang#143152 r? compiler

Rollup of 10 pull requests Successful merges: - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions) - #142138 (Add `Vec::into_chunks`) - #142321 (Expose elf abi on ppc64 targets) - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`) - #143194 (fix bitcast of single-element SIMD vectors) - #143231 (Suggest use another lifetime specifier instead of underscore lifetime) - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest) - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition) - #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic) - #143274 (ci: support optional jobs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions) - #142138 (Add `Vec::into_chunks`) - #142321 (Expose elf abi on ppc64 targets) - #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`) - #143194 (fix bitcast of single-element SIMD vectors) - #143231 (Suggest use another lifetime specifier instead of underscore lifetime) - #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest) - #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition) - #143274 (ci: support optional jobs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143231 - xizheyin:143152, r=fee1-dead Suggest use another lifetime specifier instead of underscore lifetime cc #143152 r? compiler

rustbot assigned fee1-dead Jun 30, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025

jieyouxu reviewed Jun 30, 2025

View reviewed changes

tests/ui/underscore-lifetime/in-binder.stderr Outdated Show resolved Hide resolved

xizheyin force-pushed the 143152 branch from 3198540 to c9ae0c7 Compare June 30, 2025 11:23

This comment has been minimized.

Sign in to view

fee1-dead requested changes Jun 30, 2025

View reviewed changes

compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025

xizheyin force-pushed the 143152 branch from c9ae0c7 to 2f6b711 Compare June 30, 2025 14:04

Kivooeo reviewed Jun 30, 2025

View reviewed changes

tests/ui/lifetimes/lifetime-errors/raw-annomy-lifetime-issue-143152.rs Outdated Show resolved Hide resolved

xizheyin force-pushed the 143152 branch from 2f6b711 to c3159c3 Compare July 1, 2025 06:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2025

fee1-dead requested changes Jul 1, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2025

xizheyin force-pushed the 143152 branch from c3159c3 to ff17cf8 Compare July 1, 2025 09:56

This comment has been minimized.

Sign in to view

xizheyin force-pushed the 143152 branch from ff17cf8 to 0abead2 Compare July 1, 2025 11:56

Suggest use another lifetime specifier instead of underscore lifetime

e7c3703

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

xizheyin force-pushed the 143152 branch from 0abead2 to e7c3703 Compare July 1, 2025 11:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 2, 2025

Rollup merge of rust-lang#143231 - xizheyin:143152, r=fee1-dead

406e339

Suggest use another lifetime specifier instead of underscore lifetime cc rust-lang#143152 r? compiler

jhpratt mentioned this pull request Jul 2, 2025

Rollup of 12 pull requests #143313

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025

Rollup merge of rust-lang#143231 - xizheyin:143152, r=fee1-dead

b72b0a3

Suggest use another lifetime specifier instead of underscore lifetime cc rust-lang#143152 r? compiler

matthiaskrgr mentioned this pull request Jul 2, 2025

Rollup of 11 pull requests #143317

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 2, 2025

Rollup merge of rust-lang#143231 - xizheyin:143152, r=fee1-dead

507a6fd

Suggest use another lifetime specifier instead of underscore lifetime cc rust-lang#143152 r? compiler

matthiaskrgr mentioned this pull request Jul 2, 2025

Rollup of 10 pull requests #143322

Closed

matthiaskrgr mentioned this pull request Jul 2, 2025

Rollup of 9 pull requests #143337

Merged

bors merged commit 3ff0aa5 into rust-lang:master Jul 2, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jul 2, 2025

rust-timer added a commit that referenced this pull request Jul 2, 2025

Unrolled build for #143231

0ff7518

Rollup merge of #143231 - xizheyin:143152, r=fee1-dead Suggest use another lifetime specifier instead of underscore lifetime cc #143152 r? compiler

xizheyin deleted the 143152 branch July 21, 2025 14:24

		//~^ ERROR `_` cannot be a raw lifetime
		//~\| ERROR `'_` cannot be used here [E0637]

Uh oh!

Comments

Conversation

xizheyin commented Jun 30, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

xizheyin commented Jul 1, 2025

Uh oh!

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fee1-dead Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

fee1-dead Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

fee1-dead Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

fee1-dead commented Jul 2, 2025

Uh oh!

bors commented Jul 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

xizheyin commented Jun 30, 2025 •

edited by rustbot

Loading