Add tracing to validate_operand
#143051
Draft
Add tracing to validate_operand
#143051
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the parameter changed from `op` to `val` in cbdcbf0
rustbot
added
the
T-compiler
RalfJung
reviewed
Jun 26, 2025
What happens if this gets merged without that PR? By default, all tracing is still disabled in Miri, right? |
Yes, this can be merged without issues even before rust-lang/miri#4406 |
Okay, then please make the PR & description ready for that. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tracing call to keep track of how much time is spent in
validate_operandandconst_validate_operand. Let me know if more fine-grained tracing is needed (e.g. adding tracing tovalidate_operand_internaltoo, which is just called from those two functions).I also fixed the rustdoc of
validate_operandandconst_validate_operandsince it was referencing an older name for thevalparameter which was renamed in cbdcbf0.Here is some tracing output when Miri is run on
src/tools/miri/tests/pass/hello.rs, visualizable in ui.perfetto.dev: trace-1750932222218210.jsonNote: this PR is not ready yet as it requires rust-lang/miri#4406 to disable the changes in the Miri code when "tracing" is disabled.
r? @RalfJung