Skip to content

Make named asm_labels lint not trigger on hexagon register spans #143037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2025
Merged

Make named asm_labels lint not trigger on hexagon register spans #143037

merged 2 commits into from
Nov 6, 2025

Conversation

@androm3da
Copy link
Contributor

@androm3da androm3da commented Jun 26, 2025

Fixes #143021

@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@androm3da androm3da force-pushed the bcain/hexagon_regspan_label branch from 1a4538b to 18a091e Compare June 26, 2025 02:56
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@androm3da androm3da force-pushed the bcain/hexagon_regspan_label branch from 18a091e to dea531e Compare June 26, 2025 03:17
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@SparrowLii
Copy link
Member

SparrowLii commented Jul 1, 2025

r? @workingjubilee since this relates with asm :)

@rustbot rustbot assigned workingjubilee and unassigned SparrowLii Jul 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2025

workingjubilee is currently at their maximum review capacity.
They may take a while to respond.

@workingjubilee
Copy link
Member

workingjubilee commented Jul 4, 2025

mmmh

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned workingjubilee Jul 4, 2025
@androm3da
Copy link
Contributor Author

androm3da commented Jul 7, 2025

r? @Amanieu

Maybe I should mark this PR as a draft while I work on llvm/llvm-project#146215 as a step towards a long-term solution.

@Amanieu
Copy link
Member

Amanieu commented Jul 8, 2025

Sure, though you will need to pick another reviewer on the LLVM side since I no longer have review rights in LLVM.

@wesleywiser
Copy link
Member

wesleywiser commented Sep 25, 2025

@androm3da is the plan to merge this into rustc and then eventually switch to using llvm/llvm-project#146215 in the future? If so, I guess this still needs to be reviewed?

@androm3da
Copy link
Contributor Author

androm3da commented Sep 26, 2025

@androm3da is the plan to merge this into rustc and then eventually switch to using llvm/llvm-project#146215 in the future? If so, I guess this still needs to be reviewed?

Yeah, maybe that makes the most sense. I was optimistic about making the assembler change but I just haven't gotten to spend time on it. If @Amanieu or someone else is able to review this PR that would be great. I'll still follow through on the assembler change though.

@androm3da androm3da force-pushed the bcain/hexagon_regspan_label branch from dea531e to 7c0ef85 Compare October 15, 2025 03:53
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@androm3da androm3da force-pushed the bcain/hexagon_regspan_label branch from ae8b999 to e635627 Compare October 28, 2025 19:47
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@androm3da androm3da force-pushed the bcain/hexagon_regspan_label branch from e635627 to 7cc7480 Compare October 28, 2025 23:14
@androm3da
Copy link
Contributor Author

androm3da commented Oct 28, 2025

@Amanieu PTAL when you get a chance

@Amanieu
Copy link
Member

Amanieu commented Nov 4, 2025

This seems fine to me until the relevant LLVM support lands.

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

📌 Commit 7cc7480 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 4, 2025
@Zalathar
Rollup merge of rust-lang#143037 - androm3da:bcain/hexagon_regspan_la…
6b0a5c0 
…bel, r=Amanieu

Make named asm_labels lint not trigger on hexagon register spans

Fixes rust-lang#143021
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Closed
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148458 - Zalathar:rollup-2xmquy0, r=Zalathar
11e10a4 
Rollup of 10 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #143037 (Make named asm_labels lint not trigger on hexagon register spans)
 - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar
Copy link
Member

Zalathar commented Nov 4, 2025 •
edited
Loading

Failed in rollup: #148458 (comment)

//@ add-core-stubs has been renamed to //@ add-minicore.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2025
@androm3da androm3da force-pushed the bcain/hexagon_regspan_label branch from 7cc7480 to 54df8da Compare November 6, 2025 01:43
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@workingjubilee
Copy link
Member

workingjubilee commented Nov 6, 2025

thank you so much to the folks who did the range diffs

@bors r=Amanieu

@bors
Copy link
Collaborator

bors commented Nov 6, 2025

📌 Commit 54df8da has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2025
@Zalathar Zalathar mentioned this pull request Nov 6, 2025
Merged
bors added a commit that referenced this pull request Nov 6, 2025
@bors
Auto merge of #148560 - Zalathar:rollup-c62przo, r=Zalathar
642c19b 
Rollup of 7 pull requests

Successful merges:

 - #143037 (Make named asm_labels lint not trigger on hexagon register spans)
 - #147043 (Add default sanitizers to TargetOptions)
 - #147586 (std-detect: improve detect macro docs)
 - #147912 ([rustdoc] Gracefully handle error in case we cannot run the compiler in doctests)
 - #148540 (Minor fixes to StdNonZeroNumberProvider for gdb)
 - #148541 (Add num_children method to some gdb pretty-printers)
 - #148549 (Fix broken qemu-cskyv2 link)

Failed merges:

 - #147935 (Add LLVM realtime sanitizer)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 12deb2f into rust-lang:master Nov 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 6, 2025
rust-timer added a commit that referenced this pull request Nov 6, 2025
@rust-timer
Unrolled build for #143037
8a0fff4 
Rollup merge of #143037 - androm3da:bcain/hexagon_regspan_label, r=Amanieu

Make named asm_labels lint not trigger on hexagon register spans

Fixes #143021
@asquared31415 asquared31415 mentioned this pull request Nov 6, 2025
Closed
@github-actions github-actions bot mentioned this pull request Nov 7, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

"avoid using named labels" mis-identifies inst operand as label

9 participants

@androm3da @rustbot @rust-log-analyzer @SparrowLii @workingjubilee @Amanieu @wesleywiser @bors @Zalathar