Add impl_trait_in_bindings tests from #61773 #142883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
mominul
force-pushed
the
impl_in_bindings
branch
from
05257a5 to
49ab82f
Compare
lcnr
reviewed
Jun 23, 2025
lcnr
reviewed
Jun 23, 2025
|
r=me after nits @bors delegate+ |
mominul
force-pushed
the
impl_in_bindings
branch
from
49ab82f to
2973939
Compare
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 24, 2025
Add impl_trait_in_bindings tests from rust-lang#61773 This adds the [three test cases](rust-lang#61773 (comment)) from the rust-lang#61773 as was suggested by `@lcnr.` I have merged the first two cases into one, named as `region-lifetimes.rs` r? `@lcnr` Closes rust-lang#61773
bors
added a commit
that referenced
this pull request
Jun 24, 2025
Rollup of 9 pull requests Successful merges: - #142645 (Also emit suggestions for usages in the `non_upper_case_globals` lint) - #142657 (mbe: Clean up code with non-optional `NonterminalKind`) - #142799 (rustc_session: Add a structure for keeping both explicit and default sysroots) - #142805 (Emit a single error when importing a path with `_`) - #142882 (Lazy init diagnostics-only local_names in borrowck) - #142883 (Add impl_trait_in_bindings tests from #61773) - #142943 (Don't include current rustc version string in feature removed help) - #142965 ([RTE-497] Ignore `c-link-to-rust-va-list-fn` test on SGX platform) - #142972 (Add a missing mailmap entry) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 25, 2025
Rollup merge of #142883 - mominul:impl_in_bindings, r=lcnr Add impl_trait_in_bindings tests from #61773 This adds the [three test cases](#61773 (comment)) from the #61773 as was suggested by ``@lcnr.`` I have merged the first two cases into one, named as `region-lifetimes.rs` r? ``@lcnr`` Closes #61773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the three test cases from the #61773 as was suggested by @lcnr.
I have merged the first two cases into one, named as
region-lifetimes.rsr? @lcnr
Closes #61773