Skip to content

Add caching layer to bootstrap #142816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/bootstrap/src/core/builder/cargo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ impl Cargo {
}

pub fn into_cmd(self) -> BootstrapCommand {
self.into()
let mut cmd: BootstrapCommand = self.into();
// Disable caching for commands originating from Cargo-related operations.
cmd.do_not_cache();
cmd
}

/// Same as [`Cargo::new`] except this one doesn't configure the linker with
Expand Down
3 changes: 1 addition & 2 deletions src/bootstrap/src/core/builder/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ use crate::core::build_steps::{
use crate::core::config::flags::Subcommand;
use crate::core::config::{DryRun, TargetSelection};
use crate::utils::cache::Cache;
use crate::utils::exec::{BootstrapCommand, command};
use crate::utils::execution_context::ExecutionContext;
use crate::utils::exec::{BootstrapCommand, ExecutionContext, command};
use crate::utils::helpers::{self, LldThreads, add_dylib_path, exe, libdir, linker_args, t};
use crate::{Build, Crate, trace};

Expand Down
3 changes: 1 addition & 2 deletions src/bootstrap/src/core/config/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ use crate::core::config::{
};
use crate::core::download::is_download_ci_available;
use crate::utils::channel;
use crate::utils::exec::command;
use crate::utils::execution_context::ExecutionContext;
use crate::utils::exec::{ExecutionContext, command};
use crate::utils::helpers::{exe, get_host_target};
use crate::{GitInfo, OnceLock, TargetSelection, check_ci_llvm, helpers, t};

Expand Down
4 changes: 2 additions & 2 deletions src/bootstrap/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ use cc::Tool;
use termcolor::{ColorChoice, StandardStream, WriteColor};
use utils::build_stamp::BuildStamp;
use utils::channel::GitInfo;
use utils::execution_context::ExecutionContext;
use utils::exec::ExecutionContext;

use crate::core::builder;
use crate::core::builder::Kind;
use crate::core::config::{DryRun, LldMode, LlvmLibunwind, TargetSelection, flags};
use crate::utils::exec::{BehaviorOnFailure, BootstrapCommand, CommandOutput, OutputMode, command};
use crate::utils::exec::{BootstrapCommand, command};
use crate::utils::helpers::{
self, dir_is_empty, exe, libdir, set_file_times, split_debuginfo, symlink_dir,
};
Expand Down
2 changes: 1 addition & 1 deletion src/bootstrap/src/utils/channel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use std::fs;
use std::path::Path;

use super::execution_context::ExecutionContext;
use super::exec::ExecutionContext;
use super::helpers;
use crate::Build;
use crate::utils::helpers::t;
Expand Down
Loading
Loading