-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Canonicalize input ty/ct infer/placeholder in the root universe #142732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[perf] Canonicalize input ty/ct infer/placeholder in the root universe meow
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (46d20f6): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.2%, secondary -4.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 4.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 692.244s -> 694.134s (0.27%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also rip out the compress universe for inputs, all inputs should now be in the root.
334396a
to
782f2d1
Compare
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[perf] Canonicalize input ty/ct infer/placeholder in the root universe meow
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (d69c32b): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.3%, secondary -1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 688.989s -> 688.708s (-0.04%) |
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
ty @lcnr for the suggestion, perf looks a bit better now :3 |
r? lcnr |
We shouldn't care what universe the inputs are, since we only ever do the leak check on the universes instantiated after entering the canonical binder.