Skip to content

Dont suggest remove semi inside macro expansion for redundant semi lint #142631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

xizheyin
Copy link
Contributor

@xizheyin xizheyin commented Jun 17, 2025

Fixes #142143

r? compiler

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2025
@xizheyin
Copy link
Contributor Author

r? @Urgau

@rustbot rustbot assigned Urgau and unassigned lcnr Jun 17, 2025
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
@Urgau
Copy link
Member

Urgau commented Jun 17, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

📌 Commit 72fbf3e has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2025
bors added a commit that referenced this pull request Jun 18, 2025
Rollup of 14 pull requests

Successful merges:

 - #141574 (impl `Default` for `array::IntoIter`)
 - #141608 (Add support for repetition to `proc_macro::quote`)
 - #142100 (rustdoc: make srcIndex no longer a global variable)
 - #142371 (avoid `&mut P<T>` in `visit_expr` etc methods)
 - #142517 (Windows: Use anonymous pipes in Command)
 - #142520 (alloc: less static mut + some cleanup)
 - #142588 (Generic ctx imprv)
 - #142605 (Don't unwrap in enzyme builds in case of missing llvm-config)
 - #142608 (Refresh module-level docs for `rustc_target::spec`)
 - #142618 (Lint about `console` calls in rustdoc JS)
 - #142620 (Remove a panicking branch in `BorrowedCursor::advance`)
 - #142631 (Dont suggest remove semi inside macro expansion for redundant semi lint)
 - #142632 (Update cargo)
 - #142635 (Temporarily add back -Zwasm-c-abi=spec)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f663823 into rust-lang:master Jun 18, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 18, 2025
rust-timer added a commit that referenced this pull request Jun 18, 2025
Rollup merge of #142631 - xizheyin:142143, r=Urgau

Dont suggest remove semi inside macro expansion for redundant semi lint

Fixes #142143

r? compiler
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jun 18, 2025
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#141574 (impl `Default` for `array::IntoIter`)
 - rust-lang/rust#141608 (Add support for repetition to `proc_macro::quote`)
 - rust-lang/rust#142100 (rustdoc: make srcIndex no longer a global variable)
 - rust-lang/rust#142371 (avoid `&mut P<T>` in `visit_expr` etc methods)
 - rust-lang/rust#142517 (Windows: Use anonymous pipes in Command)
 - rust-lang/rust#142520 (alloc: less static mut + some cleanup)
 - rust-lang/rust#142588 (Generic ctx imprv)
 - rust-lang/rust#142605 (Don't unwrap in enzyme builds in case of missing llvm-config)
 - rust-lang/rust#142608 (Refresh module-level docs for `rustc_target::spec`)
 - rust-lang/rust#142618 (Lint about `console` calls in rustdoc JS)
 - rust-lang/rust#142620 (Remove a panicking branch in `BorrowedCursor::advance`)
 - rust-lang/rust#142631 (Dont suggest remove semi inside macro expansion for redundant semi lint)
 - rust-lang/rust#142632 (Update cargo)
 - rust-lang/rust#142635 (Temporarily add back -Zwasm-c-abi=spec)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redundant_semicolons gets confused by macros
5 participants