Actually take --build into account in bootstrap
#142624
Open
+285
−704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went back 20 *stable* versions of Rust and I couldn't find this flag actually being used. Despite some of our CI workflows actually set this flag (!).
|
|
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
jieyouxu
approved these changes
Jun 18, 2025
|
@rustbot author |
rustbot
removed
the
S-waiting-on-review
Kobzol
force-pushed
the
bootstrap-fix-host
branch
from
1266cd3 to
aeea2e5
Compare
jieyouxu
added
the
S-waiting-on-review
|
Kewl |
bors
added
S-waiting-on-bors
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Jun 18, 2025
Actually take `--build` into account in bootstrap I went back 20 *stable* versions of Rust and I couldn't find this flag actually being used. Despite some of our CI workflows actually set this flag (!). I added destructuring of the flags to make sure that this doesn't happen again. It found one more duplicated CLI flag. r? `@jieyouxu`
bors
added a commit
that referenced
this pull request
Jun 18, 2025
Rollup of 12 pull requests Successful merges: - #135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused) - #140774 (Affirm `-Cforce-frame-pointers=off` does not override) - #141610 (Stabilize `feature(generic_arg_infer)`) - #142123 (Implement initial support for timing sections (`--json=timings`)) - #142383 (CodeGen: rework Aggregate implemention for rvalue_creates_operand cases) - #142502 (rustdoc_json: improve handling of generic args) - #142591 (Add spawn APIs for BootstrapCommand to support deferred command execution) - #142606 (AsyncDrop trait without sync Drop generates an error) - #142619 (apply clippy::or_fun_call) - #142624 (Actually take `--build` into account in bootstrap) - #142627 (Add `StepMetadata` to describe steps) - #142660 (remove joboet from review rotation) r? `@ghost` `@rustbot` modify labels: rollup
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Jun 18, 2025
Actually take `--build` into account in bootstrap I went back 20 *stable* versions of Rust and I couldn't find this flag actually being used. Despite some of our CI workflows actually set this flag (!). I added destructuring of the flags to make sure that this doesn't happen again. It found one more duplicated CLI flag. r? ``@jieyouxu``
This was referenced Jun 18, 2025
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Jun 18, 2025
Actually take `--build` into account in bootstrap I went back 20 *stable* versions of Rust and I couldn't find this flag actually being used. Despite some of our CI workflows actually set this flag (!). I added destructuring of the flags to make sure that this doesn't happen again. It found one more duplicated CLI flag. r? ```@jieyouxu```
bors
added a commit
that referenced
this pull request
Jun 18, 2025
Rollup of 11 pull requests Successful merges: - #140774 (Affirm `-Cforce-frame-pointers=off` does not override) - #141610 (Stabilize `feature(generic_arg_infer)`) - #142383 (CodeGen: rework Aggregate implemention for rvalue_creates_operand cases) - #142591 (Add spawn APIs for BootstrapCommand to support deferred command execution) - #142619 (apply clippy::or_fun_call) - #142624 (Actually take `--build` into account in bootstrap) - #142627 (Add `StepMetadata` to describe steps) - #142660 (remove joboet from review rotation) - #142666 (Skip tidy triagebot linkcheck if `triagebot.toml` doesn't exist) - #142672 (Clarify bootstrap tools description) - #142674 (remove duplicate crash test) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went back 20 stable versions of Rust and I couldn't find this flag actually being used. Despite some of our CI workflows actually set this flag (!).
I added destructuring of the flags to make sure that this doesn't happen again. It found one more duplicated CLI flag.
r? @jieyouxu