Skip to content

apply clippy::or_fun_call #142619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

apply clippy::or_fun_call #142619

wants to merge 1 commit into from

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jun 17, 2025

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

klensy
klensy commented Jun 17, 2025
View reviewed changes
@matthiaskrgr
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 17, 2025
bors added a commit that referenced this pull request Jun 17, 2025
@bors
Auto merge of #142619 - klensy:or_fun_call, r=<try>
28c89ca 
apply clippy::or_fun_call

Applies https://rust-lang.github.io/rust-clippy/master/index.html?groups=nursery#or_fun_call to reduce needless allocs.
@bors
Copy link
Collaborator

bors commented Jun 17, 2025

⌛ Trying commit 8c83935 with merge 28c89ca...

@nnethercote
Copy link
Contributor

r=me once tests pass and assuming perf comes back neutral (likely, in which case it can be rolled up) or positive.

@bors delegate=klensy

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

✌️ @klensy, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, please make that change, then do @bors r=@nnethercote

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

☀️ Try build successful - checks-actions
Build commit: 28c89ca (28c89ca0ba2ef249611acc977eef0f510fbd63dd)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (28c89ca): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 4.2% [2.9%, 5.8%] 4
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.2% [2.9%, 5.8%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 756.784s -> 691.076s (-8.68%)
Artifact size: 372.10 MiB -> 372.18 MiB (0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 18, 2025
@nnethercote
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 18, 2025

📌 Commit 8c83935 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2025
@klensy
Copy link
Contributor Author

klensy commented Jun 18, 2025

@bors rollup=maybe ?

Kobzol added a commit to Kobzol/rust that referenced this pull request Jun 18, 2025
@Kobzol
Rollup merge of rust-lang#142619 - klensy:or_fun_call, r=nnethercote
c5fd6f3 
apply clippy::or_fun_call

Applies https://rust-lang.github.io/rust-clippy/master/index.html?groups=nursery#or_fun_call to reduce needless allocs.
@Kobzol Kobzol mentioned this pull request Jun 18, 2025
Closed
bors added a commit that referenced this pull request Jun 18, 2025
@bors
Auto merge of #142665 - Kobzol:rollup-3x1yh6c, r=Kobzol
f081cca 
Rollup of 12 pull requests

Successful merges:

 - #135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused)
 - #140774 (Affirm `-Cforce-frame-pointers=off` does not override)
 - #141610 (Stabilize `feature(generic_arg_infer)`)
 - #142123 (Implement initial support for timing sections (`--json=timings`))
 - #142383 (CodeGen: rework Aggregate implemention for rvalue_creates_operand cases)
 - #142502 (rustdoc_json: improve handling of generic args)
 - #142591 (Add spawn APIs for BootstrapCommand to support deferred command execution)
 - #142606 (AsyncDrop trait without sync Drop generates an error)
 - #142619 (apply clippy::or_fun_call)
 - #142624 (Actually take `--build` into account in bootstrap)
 - #142627 (Add `StepMetadata` to describe steps)
 - #142660 (remove joboet from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol added a commit to Kobzol/rust that referenced this pull request Jun 18, 2025
@Kobzol
Rollup merge of rust-lang#142619 - klensy:or_fun_call, r=nnethercote
cecaa6d 
apply clippy::or_fun_call

Applies https://rust-lang.github.io/rust-clippy/master/index.html?groups=nursery#or_fun_call to reduce needless allocs.
@Kobzol Kobzol mentioned this pull request Jun 18, 2025
Open
Kobzol added a commit to Kobzol/rust that referenced this pull request Jun 18, 2025
@Kobzol
Rollup merge of rust-lang#142619 - klensy:or_fun_call, r=nnethercote
2c4e0a9 
apply clippy::or_fun_call

Applies https://rust-lang.github.io/rust-clippy/master/index.html?groups=nursery#or_fun_call to reduce needless allocs.
@Kobzol Kobzol mentioned this pull request Jun 18, 2025
Open
bors added a commit that referenced this pull request Jun 18, 2025
@bors
Auto merge of #142685 - Kobzol:rollup-8f3g8yf, r=Kobzol
c683403 
Rollup of 11 pull requests

Successful merges:

 - #140774 (Affirm `-Cforce-frame-pointers=off` does not override)
 - #141610 (Stabilize `feature(generic_arg_infer)`)
 - #142383 (CodeGen: rework Aggregate implemention for rvalue_creates_operand cases)
 - #142591 (Add spawn APIs for BootstrapCommand to support deferred command execution)
 - #142619 (apply clippy::or_fun_call)
 - #142624 (Actually take `--build` into account in bootstrap)
 - #142627 (Add `StepMetadata` to describe steps)
 - #142660 (remove joboet from review rotation)
 - #142666 (Skip tidy triagebot linkcheck if `triagebot.toml` doesn't exist)
 - #142672 (Clarify bootstrap tools description)
 - #142674 (remove duplicate crash test)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote left review comments

Assignees

@wesleywiser wesleywiser

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@klensy @rustbot @matthiaskrgr @rust-timer @bors @nnethercote @wesleywiser