Suggest clone in user-write-code instead of inside macro #142569
+71
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
fmease
reviewed
Jun 16, 2025
tests/ui/typeck/suggestions/suggest-clone-in-macro-issue-139253.rs
Outdated
Show resolved
Hide resolved
fmease
added
S-waiting-on-author
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
rustbot
added
S-waiting-on-review
xizheyin
commented
Jun 17, 2025
Comment on lines
+1
to
+19
| #[derive(Debug, Clone)] | ||
| struct Struct { field: S } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| struct S; | ||
|
|
||
| macro_rules! expand { | ||
| ($ident:ident) => { Struct { $ident } } | ||
| } | ||
|
|
||
| fn test1() { | ||
| let field = &S; | ||
| let a: Struct = dbg!(expand!(field)); //~ ERROR mismatched types [E0308] | ||
| let b: Struct = dbg!(Struct { field }); //~ ERROR mismatched types [E0308] | ||
| let c: S = dbg!(field); //~ ERROR mismatched types [E0308] | ||
| let c: S = dbg!(dbg!(field)); //~ ERROR mismatched types [E0308] | ||
| } | ||
|
|
||
| fn main() {} |
There was a problem hiding this comment.
I updated the test case and as you can see from the diff of the two commits, this has no effect on the shorthand case.
But this is actually strange, for the shorthand case, expr.span doesn't come from macro expansion, is this a bug? maybe fix it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139253
Inspired by #142543
r? @fmease