Skip to content

Better template for #[repr] attributes #142495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jdonszelmann
Copy link
Contributor

r? @ghost

NOTE: blocked by #138165

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-json Area: Rustdoc JSON backend T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 14, 2025
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] cc test:false 0.734
error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> compiler/rustc_attr_parsing/src/attributes/stability.rs:372:36
    |
372 |             Some(sym::old_name) => insert_value_into_option_or_error(cx, &param, &mut old_name)?,
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------- argument #4 of type `rustc_span::Ident` is missing
    |
note: function defined here
   --> compiler/rustc_attr_parsing/src/attributes/stability.rs:216:4
    |
216 | fn insert_value_into_option_or_error<S: Stage>(
    |    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
220 |     name: Ident,
    |     -----------
help: provide the argument
    |
372 |             Some(sym::old_name) => insert_value_into_option_or_error(cx, &param, &mut old_name, /* rustc_span::Ident */)?,
    |                                                                                               +++++++++++++++++++++++++

For more information about this error, try `rustc --explain E0061`.
[RUSTC-TIMING] rustc_attr_parsing test:false 0.570
error: could not compile `rustc_attr_parsing` (lib) due to 1 previous error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-json Area: Rustdoc JSON backend T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants