Bringing rustc_rayon_core in tree as rustc_thread_pool
#142384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit literally copied the directory rayon-core from revision `5fadf44`. Link: https://github.com/rust-lang/rustc-rayon/tree/5fadf44/rayon-core
rustbot
added
A-query-system
cuviper
reviewed
Jun 11, 2025
This comment has been minimized.
This comment has been minimized.
celinval
force-pushed
the
chores-rayon-mv
branch
from
9a81177 to
f52c6ee
Compare
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
the
S-waiting-on-review
oli-obk
reviewed
Jun 13, 2025
There was a problem hiding this comment.
you can delete the license files, the main licenses at the top of the repo already cover both
oli-obk
reviewed
Jun 13, 2025
|
|
||
| Rayon-core represents the "core, stable" APIs of Rayon: join, scope, and so forth, as well as the ability to create custom thread-pools with ThreadPool. | ||
|
|
||
| Maybe worth mentioning: users are not necessarily intended to directly access rayon-core; all its APIs are mirrored in the rayon crate. To that end, the examples in the docs use rayon::join and so forth rather than rayon_core::join. |
There was a problem hiding this comment.
Suggested change
| Maybe worth mentioning: users are not necessarily intended to directly access rayon-core; all its APIs are mirrored in the rayon crate. To that end, the examples in the docs use rayon::join and so forth rather than rayon_core::join. | |
| Maybe worth mentioning: users are not necessarily intended to directly access rustc_thread_pool; all its APIs are mirrored in the rayon crate. To that end, the examples in the docs use rayon::join and so forth rather than rayon_core::join. |
oli-obk
reviewed
Jun 13, 2025
|
|
||
| Maybe worth mentioning: users are not necessarily intended to directly access rayon-core; all its APIs are mirrored in the rayon crate. To that end, the examples in the docs use rayon::join and so forth rather than rayon_core::join. | ||
|
|
||
| rayon-core aims to never, or almost never, have a breaking change to its API, because each revision of rayon-core also houses the global thread-pool (and hence if you have two simultaneous versions of rayon-core, you have two thread-pools). |
There was a problem hiding this comment.
Suggested change
| rayon-core aims to never, or almost never, have a breaking change to its API, because each revision of rayon-core also houses the global thread-pool (and hence if you have two simultaneous versions of rayon-core, you have two thread-pools). |
not needed anymore
oli-obk
reviewed
Jun 13, 2025
|
|
||
| [Rayon Docs]: https://docs.rs/rayon/ | ||
|
|
||
| Rayon-core currently requires `rustc 1.63.0` or greater. |
There was a problem hiding this comment.
Suggested change
| Rayon-core currently requires `rustc 1.63.0` or greater. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
rustc_rayon_corefrom commit5fadf44as suggested in this zulip thread. I tried to split the work into separate commits so it is easy to review. The first commit is a simple copy and paste from the fork, and subsequent changes were made to use the new crate and to ensure the new crate complies with different format and lint expectations.Call-out: I was also wondering if I need to make any further changes to accommodate licensing requirements.
r? oli-obk