Skip to content

Async drop - fix for StorageLive/StorageDead codegen for pinned future #142347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Async drop - fix for StorageLive/StorageDead codegen for pinned future #142347

wants to merge 1 commit into from
+387 −9

Conversation

azhogin
Copy link
Contributor

@azhogin azhogin commented Jun 11, 2025 •
edited by rustbot
Loading

Fixes: #140429, Fixes: #140531, Fixes: #141761, Fixes: #141409.

StorageLive/StorageDead codegen is corrected for pinned async drop future.

@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@azhogin
Copy link
Contributor Author

azhogin commented Jun 11, 2025

r? oli-obk

@rustbot rustbot assigned oli-obk and unassigned lcnr Jun 11, 2025
oli-obk
oli-obk reviewed Jun 11, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jun 11, 2025
View reviewed changes
@petrochenkov petrochenkov added the F-async_drop `#![feature(async_drop)]` label Jun 11, 2025
@azhogin azhogin force-pushed the azhogin/async-drop-storage-live-dead-fix branch from 996c127 to 189e64c Compare June 14, 2025 01:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin azhogin force-pushed the azhogin/async-drop-storage-live-dead-fix branch from 189e64c to df2072b Compare June 14, 2025 01:41
@rust-log-analyzer

This comment has been minimized.

Sign in to view
oli-obk
oli-obk reviewed Jun 14, 2025
View reviewed changes
@azhogin azhogin force-pushed the azhogin/async-drop-storage-live-dead-fix branch from df2072b to d6a9081 Compare June 14, 2025 08:10
@oli-obk
Copy link
Contributor

oli-obk commented Jun 14, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 14, 2025

📌 Commit d6a9081 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
F-async_drop `#![feature(async_drop)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
7 participants
@azhogin @rustbot @rust-log-analyzer @oli-obk @bors @petrochenkov @lcnr