Skip to content

add Vec::peek_mut #142046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 14, 2025
Merged

add Vec::peek_mut #142046

merged 4 commits into from
Jun 14, 2025

Conversation

Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Jun 4, 2025

Tracking issue: #122742

@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 4, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Qelxiros Qelxiros force-pushed the 122742-vec_peek_mut branch from 03bfedb to cc80429 Compare June 6, 2025 23:22
@Qelxiros
Copy link
Contributor Author

Qelxiros commented Jun 6, 2025

In fixing the broken test, I realized it's a little unergonomic to check the value of a PeekMut (*p == other_val instead of p == other_val). Is it worth adding trivial implementations of (Partial)(Ord|Eq)?

@rust-log-analyzer

This comment has been minimized.

@cuviper
Copy link
Member

cuviper commented Jun 7, 2025

I realized it's a little unergonomic to check the value of a PeekMut (*p == other_val instead of p == other_val). Is it worth adding trivial implementations of (Partial)(Ord|Eq)?

Following binary_heap::PeekMut, and other wrappers like cell::Ref, I'd say no.

@cuviper
Copy link
Member

cuviper commented Jun 13, 2025

Thanks!

r? cuviper
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 13, 2025

📌 Commit 9d19cbe has been approved by cuviper

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 13, 2025
bors added a commit that referenced this pull request Jun 14, 2025
Rollup of 16 pull requests

Successful merges:

 - #140969 (Allow initializing logger with additional tracing Layer)
 - #141352 (builtin dyn impl no guide inference)
 - #142046 (add Vec::peek_mut)
 - #142273 (tests: Minicore `extern "gpu-kernel"` feature test)
 - #142302 (Rework how the disallowed qualifier in function type diagnostics are generated)
 - #142405 (Don't hardcode the intrinsic return types twice in the compiler)
 - #142434 ( Pre-install JS dependencies in tidy Dockerfile)
 - #142439 (doc: mention that intrinsics should not be called in user code)
 - #142441 (Delay replacing escaping bound vars in `FindParamInClause`)
 - #142449 (Require generic params for const generic params)
 - #142452 (Remove "intermittent" wording from `ReadDir`)
 - #142459 (Remove output helper bootstrap)
 - #142460 (cleanup search graph impl)
 - #142461 (compiletest: Clarify that `--no-capture` is needed with `--verbose`)
 - #142475 (Add platform support docs & maintainers for *-windows-msvc)
 - #142480 (tests: Convert two handwritten minicores to add-core-stubs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b38ee5e into rust-lang:master Jun 14, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 14, 2025
rust-timer added a commit that referenced this pull request Jun 14, 2025
Rollup merge of #142046 - Qelxiros:122742-vec_peek_mut, r=cuviper

add Vec::peek_mut

Tracking issue: #122742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants