transmutability: shift abstraction boundary #142040
Open
+385
−357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
fbstj
reviewed
Jun 4, 2025
| if self.is_mut { | ||
| f.write_str("mut ")?; | ||
| } | ||
| self.referent.fmt(f) |
There was a problem hiding this comment.
silly question: is this intentionally msising the region field?
There was a problem hiding this comment.
Yeah, this PR aims to be more or less behavior-preserving. This Display impl is only here for convenience while debugging and isn't encountered by end-users.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #142099) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
jswrenn
force-pushed
the
transmute-ty-region-generic
branch
from
e059b8b to
4f959a7
Compare
Previously, `rustc_transmute`'s layout representations were genericized over `R`, a reference. Now, it's instead genericized over representations of type and region. This allows us to move reference transmutability logic from `rustc_trait_selection` to `rustc_transmutability` (and thus unit test it independently of the compiler), and — in a follow-up PR — will make it possible to support analyzing function pointer transmutability with minimal surgery.
jswrenn
force-pushed
the
transmute-ty-region-generic
branch
from
4f959a7 to
e9eae28
Compare
rustbot
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
rustc_transmute's layout representations were genericized overR, a reference. Now, it's instead genericized over representations of type and region. This allows us to move reference transmutability logic fromrustc_trait_selectiontorustc_transmutability(and thus unit test it independently of the compiler), and — in a follow-up PR — will make it possible to support analyzing function pointer transmutability with minimal surgery.r? @compiler-errors