Rollup of 11 pull requests #142033

matthiaskrgr · 2025-06-04T17:50:28Z

Successful merges:

Add link to correct documentation in htmldocck.py #141890 (Add link to correct documentation in htmldocck.py)
Fix for async drop inside async gen fn #141932 (Fix for async drop inside async gen fn)
Use non-2015 edition paths in tests that do not test for their resolution #141960 (Use non-2015 edition paths in tests that do not test for their resolution)
Run wfcheck in one big loop instead of per module #141968 (Run wfcheck in one big loop instead of per module)
Triagebot: Remove assign.users_on_vacation #141969 (Triagebot: Remove assign.users_on_vacation)
Ensure query keys are printed with reduced queries #141985 (Ensure query keys are printed with reduced queries)
Visit the ident in PreciseCapturingNonLifetimeArg. #141999 (Visit the ident in PreciseCapturingNonLifetimeArg.)
Change tag_field to FieldIdx in Variants::Multiple #142005 (Change tag_field to FieldIdx in Variants::Multiple)
Fix incorrect use of "recommend" over "recommended" #142017 (Fix incorrect use of "recommend" over "recommended")
Don't refer to 'this tail expression' in expansion. #142024 (Don't refer to 'this tail expression' in expansion.)
Don't refer to 'local binding' in extern macro. #142025 (Don't refer to 'local binding' in extern macro.)

r? @ghost
@rustbot modify labels: rollup

…tion This allows for testing these tests on editions other than 2015

It's currently skipped, presumably by accident.

It was already available as a generic parameter anyway, and it's not like we'll ever put a tag in the 5-billionth field.

Fix typo in src/etc/htmldocck.py Co-authored-by: León Orell Valerian Liehr <me@fmease.dev> Change documentation link to the correct section in src/etc/htmldocck.py Co-authored-by: León Orell Valerian Liehr <me@fmease.dev> Remove all top-level docs from htmldocck.py

The user has no clue what 'local binding' the compiler is talking about, if they don't know the expansion of the macro.

The user has no clue what tail expression the compiler is talking about: it is an implementation detail of the macro that it uses a block with tail expression.

Add link to correct documentation in htmldocck.py

…asyncgen-fix, r=oli-obk Fix for async drop inside async gen fn Return value (for yield) is corrected for async drop inside async gen function. In CFG, when internal async drop future is polled and returned `Poll<()>::Pending`, then async gen resume function returns `Poll<(OptRet)>::Pending`. Fixes rust-lang#140530

…er-errors Use non-2015 edition paths in tests that do not test for their resolution This allows for testing these tests on editions other than 2015 Follow up to rust-lang#141888

…=wesleywiser Run wfcheck in one big loop instead of per module Maybe we can merge this big loop in the future with the `par_hir_body_owners` call below and run typeck only on items that didn't fail wfcheck. For now let's just see if perf likes it, as it by itself should be beneficial to parallel rustc

…n-vacation, r=Kobzol Triagebot: Remove `assign.users_on_vacation` It's been superseded by triagebot's [review queue tracking](https://forge.rust-lang.org/triagebot/review-queue-tracking.html), more specifically *rotation mode*. r? Kobzol or triagebot

…-print, r=oli-obk Ensure query keys are printed with reduced queries Using `-Z query-dep-graph` and debug assertions leads to an ICE that was originally discovered in rust-lang#141700: > This isn't an incremental bug per se, but instead a bug that has to do with debug printing query keys when debug assertions and `-Z query-dep-graph` is enabled. We end up printing a const (b/c we're using generic const args here) whose debug printing for -Z query-dep-graph requires invoking the same query cyclically 😃 > > I've pushed a commit which should fix this. This isn't related to the standard library changes, but instead b/c it seems to be the first usage of `feature(adt_const_params)` in the standard library that ends up being triggered in incremental tests. r? oli-obk

…ler-errors Visit the ident in `PreciseCapturingNonLifetimeArg`. It's currently skipped, presumably by accident. r? `@BoxyUwU`

…ple, r=workingjubilee Change `tag_field` to `FieldIdx` in `Variants::Multiple` It was already available as a generic parameter anyway, and it's not like we'll ever put a tag in the 5-billionth field. This is a first part of pulling smaller pieces out of rust-lang#138759, so r? workingjubilee

…ommend-over-recommended, r=lqd Fix incorrect use of "recommend" over "recommended" Spotted this typo in rust-lang#141554, but it has since been merged. r? `@Noratrieb`

…trochenkov Don't refer to 'this tail expression' in expansion. The user has no clue what the compiler is talking about when it says "this tail expression". It is an implementation detail of the macro that it uses a block with tail expression.

…nszelmann Don't refer to 'local binding' in extern macro. When it comes from a macro expansion, the user has no clue what 'local binding' the compiler is talking about, if they don't know the expansion of the macro. Better to just say 'temporary value'.

matthiaskrgr · 2025-06-04T17:51:06Z

@bors r+ rollup=never p=1

bors · 2025-06-04T17:51:08Z

📌 Commit 4959ee3 has been approved by matthiaskrgr

It is now in the queue for this repository.

matthiaskrgr · 2025-06-04T21:07:28Z

@bors p=5

bors · 2025-06-05T00:30:12Z

⌛ Testing commit 4959ee3 with merge 81a964c...

bors · 2025-06-05T03:52:31Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 81a964c to master...

github-actions · 2025-06-05T03:55:21Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ff223d3 (parent) -> 81a964c (this PR)

Test differences

Show 6 test diffs

Stage 1

[crashes] tests/crashes/140530.rs: pass -> [missing] (J1)
[incremental] tests/incremental/print-dep-node-cycle.rs: [missing] -> pass (J1)
[ui] tests/ui/async-await/async-drop/assign-incompatible-types.rs: [missing] -> pass (J1)

Stage 2

[crashes] tests/crashes/140530.rs: pass -> [missing] (J0)
[incremental] tests/incremental/print-dep-node-cycle.rs: [missing] -> pass (J0)
[ui] tests/ui/async-await/async-drop/assign-incompatible-types.rs: [missing] -> pass (J2)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 81a964c23ea4fe9ab52b4449bb166bf280035797 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 5897.4s -> 7981.6s (35.3%)
x86_64-apple-2: 6010.6s -> 4251.8s (-29.3%)
dist-x86_64-apple: 8227.7s -> 9736.7s (18.3%)
dist-apple-various: 6004.3s -> 6840.7s (13.9%)
x86_64-apple-1: 8162.6s -> 7196.0s (-11.8%)
dist-armhf-linux: 4692.9s -> 5147.2s (9.7%)
x86_64-gnu-aux: 6091.7s -> 5618.3s (-7.8%)
dist-loongarch64-musl: 4907.0s -> 5278.2s (7.6%)
dist-arm-linux-musl: 5702.5s -> 5340.3s (-6.4%)
dist-powerpc64le-linux-musl: 5111.7s -> 5430.2s (6.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-05T03:55:40Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#141890	Add link to correct documentation in htmldocck.py	`e427332a1070e79ec117a9ebc7f43b79593e11b0` (link)
#141932	Fix for async drop inside async gen fn	`a323f1882ef545c7ffb84017bd15952995ba801f` (link)
#141960	Use non-2015 edition paths in tests that do not test for th…	`a1f008c7cf71cbcccb532fb0ebef258d5edd3226` (link)
#141968	Run wfcheck in one big loop instead of per module	`8291611a2345b8808541dc571bb0c93be837036b` (link)
#141969	Triagebot: Remove `assign.users_on_vacation`	`6b945f36369b6a2bb1833f7cab4480cc23f9ce3d` (link)
#141985	Ensure query keys are printed with reduced queries	`a7e5720d8e58a3599cd545bf7b616eaaeef61043` (link)
#141999	Visit the ident in `PreciseCapturingNonLifetimeArg`.	`6ecb9bf1097437d44c2da1457812f88426df9e57` (link)
#142005	Change `tag_field` to `FieldIdx` in `Variants::Multiple`	`2ae7c3d670c0edf636c1c63929099f4395f48896` (link)
#142017	Fix incorrect use of "recommend" over "recommended"	`d715aa0c875f61f8ff5bd359d9386d9e30474299` (link)
#142024	Don't refer to 'this tail expression' in expansion.	`96e60ab56ed2d87a0a2926c3ffc60b60a5a4c269` (link)
#142025	Don't refer to 'local binding' in extern macro.	`7b28ccde33f8cb3750872f26b41476be941740fa` (link)

previous master: ff223d35cd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-06-05T05:23:32Z

Finished benchmarking commit (81a964c): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.1%, 0.8%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.5%, secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.3%, 1.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-2.5%	[-5.9%, -0.7%]	4
All ❌✅ (primary)	0.5%	[-1.6%, 1.7%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.112s -> 750.423s (-0.09%)
Artifact size: 371.83 MiB -> 371.83 MiB (-0.00%)

matthiaskrgr · 2025-06-05T05:52:58Z

perf changes might be from #141968 ? 🤔

Veykril and others added 23 commits June 3, 2025 13:35

Use non-2015 edition paths in tests that do not test for their resolu…

eae7fe1

…tion This allows for testing these tests on editions other than 2015

Run wfcheck in one big loop instead of per module

82ed50c

Triagebot: Remove assign.users_on_vacation

2b2f66a

Add a test to reproduce ICE

f7db329

Ensure query keys are printed with reduced queries

cbb3a84

Visit the ident in PreciseCapturingNonLifetimeArg.

f9c2a45

It's currently skipped, presumably by accident.

Change tag_field to FieldIdx in Variants::Multiple

ee9901e

It was already available as a generic parameter anyway, and it's not like we'll ever put a tag in the 5-billionth field.

Fix incorrect use of "recommend" over "recommended"

be70a4b

Fix for async drop inside async gen fn

d5a9a00

Don't refer to 'local binding' in extern macro.

fcfa9b0

The user has no clue what 'local binding' the compiler is talking about, if they don't know the expansion of the macro.

Don't refer to 'this tail expression' in expansion.

da2e33b

The user has no clue what tail expression the compiler is talking about: it is an implementation detail of the macro that it uses a block with tail expression.

Rollup merge of rust-lang#141890 - Derukugis:master, r=fmease

4151d15

Add link to correct documentation in htmldocck.py

Rollup merge of rust-lang#141960 - ferrocene:lw/2015-paths2, r=compil…

be2d382

…er-errors Use non-2015 edition paths in tests that do not test for their resolution This allows for testing these tests on editions other than 2015 Follow up to rust-lang#141888

Rollup merge of rust-lang#141999 - nnethercote:precise-ident, r=compi…

87969ff

…ler-errors Visit the ident in `PreciseCapturingNonLifetimeArg`. It's currently skipped, presumably by accident. r? `@BoxyUwU`

Rollup merge of rust-lang#142017 - Rageking8:fix-incorrect-use-of-rec…

8375ab0

…ommend-over-recommended, r=lqd Fix incorrect use of "recommend" over "recommended" Spotted this typo in rust-lang#141554, but it has since been merged. r? `@Noratrieb`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 5, 2025

bors merged commit 81a964c into rust-lang:master Jun 5, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 5, 2025

This was referenced Jun 5, 2025

Sized Hierarchy: Part I #137944

Open

Fix glob import tests #141060

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests #142033

Rollup of 11 pull requests #142033

Uh oh!

matthiaskrgr commented Jun 4, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

matthiaskrgr commented Jun 4, 2025

Uh oh!

bors commented Jun 5, 2025

Uh oh!

bors commented Jun 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jun 5, 2025

Uh oh!

rust-timer commented Jun 5, 2025

Uh oh!

matthiaskrgr commented Jun 5, 2025

Uh oh!

Uh oh!

Rollup of 11 pull requests #142033

Rollup of 11 pull requests #142033

Uh oh!

Conversation

matthiaskrgr commented Jun 4, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

matthiaskrgr commented Jun 4, 2025

Uh oh!

bors commented Jun 5, 2025

Uh oh!

bors commented Jun 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 5, 2025

Uh oh!

rust-timer commented Jun 5, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

matthiaskrgr commented Jun 5, 2025

Uh oh!

Uh oh!

matthiaskrgr commented Jun 4, 2025 •

edited by rustbot

Loading