-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Use the in-tree compiler-builtins
for the sysroot
#141993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
WIP: Use the in-tree compiler-builtins for the sysroot Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336) try-job: x86_64-gnu try-job: test-various
94592d3
to
3c91330
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
e3edcc4
to
145c702
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
WIP: Use the in-tree compiler-builtins for the sysroot Many of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead. `compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future. Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336) try-job: x86_64-gnu try-job: x86_64-gnu-aux try-job: test-various
This comment was marked as outdated.
This comment was marked as outdated.
145c702
to
a543f01
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Test with RalfJung/rustc-build-sysroot#27 @bors2 try |
Use the in-tree `compiler-builtins` for the sysroot Many of `std`'s dependency have a dependency on the crates.io `compiler-builtins` when used with the feature `rustc-std-workspace-core`. Use a Cargo patch to select the in-tree version instead. `compiler-builtins` is also added as a dependency of `rustc-std-workspace-core` so these crates can remove their crates.io dependency in the future. Zulip discussion: [#t-compiler > Using in-tree compiler-builtins](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Using.20in-tree.20compiler-builtins/with/522445336) Once this merges, the following PRs will need to make it to a release for the relevant crates: - rust-lang/getopts#119 (can merge at any time) - rust-lang/hashbrown#625 (can merge at any time) - rust-lang/stdarch#1825 - rust-lang/rustc-demangle#80 - rust-lang/cfg-if#84 - unicode-rs/unicode-width#77 The above should cover all tier 1 targets. The remaining cover the rest: - `dlmalloc` (wasm, xous, sgx) alexcrichton/dlmalloc-rs#50 - `gimli` (xous) - `r-efi`, `r-efi-alloc` (efi) - `fortanix-sgx-abi` (sgx) - `hermit-abi` (hermit) - `wasi` (wasi) try-job: dist-x86_64-linux try-job: x86_64-gnu try-job: x86_64-gnu-aux try-job: test-various
@ehuss was able to verify this didn't seem to break Cargo things: https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/Testing.20with.20a.20specific.20rust-lang.2Frust.20PR/with/522678293 |
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang/rust#141993
Many of
std
's dependency have a dependency on the crates.iocompiler-builtins
when used with the featurerustc-std-workspace-core
. Use a Cargo patch to select the in-tree version instead.compiler-builtins
is also added as a dependency ofrustc-std-workspace-core
so these crates can remove their crates.io dependency in the future.Zulip discussion: #t-compiler > Using in-tree compiler-builtins
Once this merges, the following PRs will need to make it to a release for the relevant crates:
compiler-builtins
fromrustc-dep-of-std
dependencies stdarch#1825compiler-builtins
fromrustc-dep-of-std
dependencies rustc-demangle#80compiler-builtins
fromrustc-dep-of-std
dependencies cfg-if#84compiler-builtins
fromrustc-dep-of-std
dependencies unicode-rs/unicode-width#77The above should cover all tier 1 targets with no
std
features enabled. The remaining cover the rest:compiler-builtins
fromrustc-dep-of-std
dependencies alexcrichton/dlmalloc-rs#50 (wasm, xous, sgx)compiler-builtins
fromrustc-dep-of-std
dependencies gimli-rs/gimli#769compiler-builtins
fromrustc-dep-of-std
dependencies r-efi/r-efi#89 (efi)compiler-builtins
fromrustc-dep-of-std
dependencies r-efi/r-efi-alloc#9 (efi)compiler-builtins
fromrustc-dep-of-std
dependencies fortanix/rust-sgx#770 (sgx)compiler-builtins
fromrustc-dep-of-std
dependencies hermit-os/hermit-rs#718 (hermit)compiler-builtins
fromrustc-dep-of-std
dependencies bytecodealliance/wasi-rs#108 (wasi)compiler-builtins
fromrustc-dep-of-std
dependencies gimli-rs/addr2line#345compiler-builtins
fromrustc-dep-of-std
dependencies oyvindln/adler2#2compiler-builtins
fromrustc-dep-of-std
dependencies BurntSushi/memchr#180compiler-builtins
fromrustc-dep-of-std
dependencies Frommi/miniz_oxide#173compiler-builtins
fromrustc-dep-of-std
dependencies gimli-rs/object#777try-job: dist-x86_64-linux
try-job: x86_64-gnu
try-job: x86_64-gnu-aux
try-job: test-various