Skip to content

Remove two trait methods from cg_ssa #141956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

Remove two trait methods from cg_ssa #141956

merged 2 commits into from
Jun 3, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jun 3, 2025

They are only called by cg_llvm.

bjorn3 added 2 commits June 3, 2025 10:00
@bjorn3
Remove get_dbg_loc from DebugInfoBuilderMethods
00a88b9 
It is only used within cg_llvm.
@bjorn3
Remove type_test from IntrinsicCallBuilderMethods
2e8401a 
It is only used within cg_llvm.
@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@oli-obk
Copy link
Contributor

oli-obk commented Jun 3, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 3, 2025

📌 Commit 2e8401a has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 3, 2025
Merged
bors added a commit that referenced this pull request Jun 3, 2025
@bors
Auto merge of #141961 - matthiaskrgr:rollup-r09j2sp, r=matthiaskrgr
a124fb3 
Rollup of 8 pull requests

Successful merges:

 - #141724 (fix(#141141): When expanding `PartialEq`, check equality of scalar types first.)
 - #141833 (`tests/ui`: A New Order [2/N])
 - #141861 (Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images)
 - #141914 (redesign stage 0 std follow-ups)
 - #141918 (Deconstruct values in the THIR visitor)
 - #141923 (Update books)
 - #141931 (Deconstruct values in the THIR visitor)
 - #141956 (Remove two trait methods from cg_ssa)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3772a16 into rust-lang:master Jun 3, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 3, 2025
@rust-timer
Unrolled build for #141956
b421810 
Rollup merge of #141956 - bjorn3:minor_cg_ssa_cleanup, r=oli-obk

Remove two trait methods from cg_ssa

They are only called by cg_llvm.
@rustbot rustbot added this to the 1.89.0 milestone Jun 3, 2025
@bjorn3 bjorn3 deleted the minor_cg_ssa_cleanup branch June 3, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bjorn3 @rustbot @oli-obk @bors