Deconstruct values in the THIR visitor #141918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
|
Failed to set assignee to
|
This comment has been minimized.
This comment has been minimized.
|
r? @nnethercote |
ArtemIsmagilov
force-pushed
the
issue-141849
branch
from
fab28a1 to
cdeaff9
Compare
This comment has been minimized.
This comment has been minimized.
ArtemIsmagilov
changed the title
compiler/rustc_middle/src/thir/visit.rs with refaccompiler/rustc_middle/src/thir/visit.rs
nnethercote
changed the title
compiler/rustc_middle/src/thir/visit.rscompiler/rustc_middle/src/thir/visit.rs
|
Looks good! Can you squash the two commits together with |
nnethercote
changed the title
compiler/rustc_middle/src/thir/visit.rs
|
Hello, thanks for the review! I'll fix it now |
ArtemIsmagilov
force-pushed
the
issue-141849
branch
from
c23f31c to
41c6a71
Compare
ArtemIsmagilov
force-pushed
the
issue-141849
branch
from
41c6a71 to
ee99fba
Compare
|
Nice work :) @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 3, 2025
Rollup of 8 pull requests Successful merges: - #141724 (fix(#141141): When expanding `PartialEq`, check equality of scalar types first.) - #141833 (`tests/ui`: A New Order [2/N]) - #141861 (Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images) - #141914 (redesign stage 0 std follow-ups) - #141918 (Deconstruct values in the THIR visitor) - #141923 (Update books) - #141931 (Deconstruct values in the THIR visitor) - #141956 (Remove two trait methods from cg_ssa) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 3, 2025
Rollup merge of #141918 - ArtemIsmagilov:issue-141849, r=nnethercote Deconstruct values in the THIR visitor Hi! I am a beginner rust developer. I'm trying to solve your problem #141849 I see that 2 files need to be corrected, so I’m starting with a simpler step, `compiler/rustc_middle/src/thir/visit.rs` r? `@krikera`
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Jun 9, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#141724 (fix(rust-lang/rust#141141): When expanding `PartialEq`, check equality of scalar types first.) - rust-lang/rust#141833 (`tests/ui`: A New Order [2/N]) - rust-lang/rust#141861 (Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images) - rust-lang/rust#141914 (redesign stage 0 std follow-ups) - rust-lang/rust#141918 (Deconstruct values in the THIR visitor) - rust-lang/rust#141923 (Update books) - rust-lang/rust#141931 (Deconstruct values in the THIR visitor) - rust-lang/rust#141956 (Remove two trait methods from cg_ssa) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I am a beginner rust developer.
I'm trying to solve your problem #141849
I see that 2 files need to be corrected, so I’m starting with a simpler step,
compiler/rustc_middle/src/thir/visit.rsr? @krikera