Skip to content

Deconstruct values in the THIR visitor #141918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

ArtemIsmagilov
Copy link
Contributor

@ArtemIsmagilov ArtemIsmagilov commented Jun 2, 2025

Hi! I am a beginner rust developer.
I'm trying to solve your problem #141849
I see that 2 files need to be corrected, so I’m starting with a simpler step, compiler/rustc_middle/src/thir/visit.rs

r? @krikera

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

Failed to set assignee to krikera: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rust-log-analyzer

This comment has been minimized.

@workingjubilee
Copy link
Member

r? @nnethercote

@rust-log-analyzer

This comment has been minimized.

@ArtemIsmagilov ArtemIsmagilov changed the title try decostruct in values in compiler/rustc_middle/src/thir/visit.rs with refac try decostruct in values in compiler/rustc_middle/src/thir/visit.rs Jun 2, 2025
@nnethercote nnethercote changed the title try decostruct in values in compiler/rustc_middle/src/thir/visit.rs try deconstruct in values in compiler/rustc_middle/src/thir/visit.rs Jun 3, 2025
@nnethercote
Copy link
Contributor

Looks good!

Can you squash the two commits together with git rebase and give the single commit a title something like "Deconstruct values in the THIR visitor"? Thanks.

@nnethercote nnethercote changed the title try deconstruct in values in compiler/rustc_middle/src/thir/visit.rs Deconstruct values in the THIR visitor Jun 3, 2025
@ArtemIsmagilov
Copy link
Contributor Author

Hello, thanks for the review! I'll fix it now

@nnethercote
Copy link
Contributor

Nice work :)

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 3, 2025

📌 Commit ee99fba has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2025
bors added a commit that referenced this pull request Jun 3, 2025
Rollup of 8 pull requests

Successful merges:

 - #141724 (fix(#141141): When expanding `PartialEq`, check equality of scalar types first.)
 - #141833 (`tests/ui`: A New Order [2/N])
 - #141861 (Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images)
 - #141914 (redesign stage 0 std follow-ups)
 - #141918 (Deconstruct values in the THIR visitor)
 - #141923 (Update books)
 - #141931 (Deconstruct values in the THIR visitor)
 - #141956 (Remove two trait methods from cg_ssa)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e61cd14 into rust-lang:master Jun 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 3, 2025
rust-timer added a commit that referenced this pull request Jun 3, 2025
Rollup merge of #141918 - ArtemIsmagilov:issue-141849, r=nnethercote

Deconstruct values in the THIR visitor

Hi! I am a beginner rust developer.
I'm trying to solve your problem #141849
I see that 2 files need to be corrected, so I’m starting with a simpler step,  `compiler/rustc_middle/src/thir/visit.rs`

r? `@krikera`
@ArtemIsmagilov ArtemIsmagilov deleted the issue-141849 branch June 4, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants