-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Deconstruct values in the THIR visitor #141918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
Failed to set assignee to
|
This comment has been minimized.
This comment has been minimized.
r? @nnethercote |
fab28a1
to
cdeaff9
Compare
This comment has been minimized.
This comment has been minimized.
compiler/rustc_middle/src/thir/visit.rs
with refaccompiler/rustc_middle/src/thir/visit.rs
compiler/rustc_middle/src/thir/visit.rs
compiler/rustc_middle/src/thir/visit.rs
Looks good! Can you squash the two commits together with |
compiler/rustc_middle/src/thir/visit.rs
Hello, thanks for the review! I'll fix it now |
c23f31c
to
41c6a71
Compare
41c6a71
to
ee99fba
Compare
Nice work :) @bors r+ rollup |
Rollup of 8 pull requests Successful merges: - #141724 (fix(#141141): When expanding `PartialEq`, check equality of scalar types first.) - #141833 (`tests/ui`: A New Order [2/N]) - #141861 (Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images) - #141914 (redesign stage 0 std follow-ups) - #141918 (Deconstruct values in the THIR visitor) - #141923 (Update books) - #141931 (Deconstruct values in the THIR visitor) - #141956 (Remove two trait methods from cg_ssa) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #141918 - ArtemIsmagilov:issue-141849, r=nnethercote Deconstruct values in the THIR visitor Hi! I am a beginner rust developer. I'm trying to solve your problem #141849 I see that 2 files need to be corrected, so I’m starting with a simpler step, `compiler/rustc_middle/src/thir/visit.rs` r? `@krikera`
Hi! I am a beginner rust developer.
I'm trying to solve your problem #141849
I see that 2 files need to be corrected, so I’m starting with a simpler step,
compiler/rustc_middle/src/thir/visit.rs
r? @krikera