Skip to content

Rollup of 5 pull requests #141912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 2, 2025
Merged

Rollup of 5 pull requests #141912

merged 10 commits into from
Jun 2, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 2, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

marcoieni and others added 10 commits May 30, 2025 15:08
@marcoieni
ci: use free runner for aarch64-gnu-llvm-19-1 PR job
7ad2c36
@zacryol
Fix typo in StructuralPartialEq docs
33127af 
`equialent` => `equivalent`
@Nadrieril
Optionally don't steal the THIR
1e169d8
@usamoi
add f16_epsilon and f128_epsilon
d948907
@jieyouxu
test-float-parse: apply cfg(not(bootstrap))
8788b6a 
Prior to stage 0 redesign, `test-float-parse` ran against in-tree std
but now it runs against beta std. `f16::FromStr` were only present in
in-tree std and not yet beta std, so apply `cfg(not(bootstrap))` gating
to unbrick `./x check --stage=0`.
@Kobzol
Rollup merge of rust-lang#141767 - marcoieni:free-pr-job, r=Kobzol
2cb5b0d 
ci: use free runner for aarch64-gnu-llvm-19-1 PR job
@Kobzol
Rollup merge of rust-lang#141858 - zacryol:spe-docs-typo, r=aDotInThe…
aeb72a0 
…Void

Fix typo in `StructuralPartialEq` docs

`equialent` => `equivalent`
@Kobzol
Rollup merge of rust-lang#141865 - Nadrieril:dont-steal-thir, r=oli-obk
f8e756b 
Optionally don't steal the THIR

The THIR being stolen is a recurrent pain for authors of rustc drivers. This makes it optional, so that the `thir_body` query can still be used after analysis of the crate has completed.
@Kobzol
Rollup merge of rust-lang#141874 - usamoi:eps, r=tgross35
b2743c7 
add f16_epsilon and f128_epsilon diagnostic items

cc rust-lang#116909
r? ``@tgross35``
@Kobzol
Rollup merge of rust-lang#141904 - jieyouxu:test-float-parse, r=Mark-…
44ba243 
…Simulacrum

test-float-parse: apply `cfg(not(bootstrap))`

Prior to stage 0 redesign, `test-float-parse` ran against in-tree std but now it runs against beta std. `f16::FromStr` is only present in in-tree std and not yet beta std, so apply `cfg(not(bootstrap))` gating to unbrick `./x check --stage=0`.

Fixes rust-lang#141900.

`./x check --stage=0` in CI is intended for follow-up.

r? `@Mark-Simulacrum` (or bootstrap/libs)
cc `@tgross35`
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 2, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 2, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 44ba243 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
@bors
Copy link
Collaborator

bors commented Jun 2, 2025

⌛ Testing commit 44ba243 with merge 5d707b0...

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 5d707b0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2025
@bors bors merged commit 5d707b0 into rust-lang:master Jun 2, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 2, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#141767 ci: use free runner for aarch64-gnu-llvm-19-1 PR job 8aa2e9a7355f9b57f0cc5d4ddf09037ae9598aeb (link)
#141858 Fix typo in StructuralPartialEq docs 5e9b56c8bb0be4a9e375b3de1cfc99eecea2d5e0 (link)
#141865 Optionally don't steal the THIR 6e87d2a6b5d580855714de740225fd65a3ce356e (link)
#141874 add f16_epsilon and f128_epsilon diagnostic items b354f5028aafc7f0e690efc93d4490c3d4486636 (link)
#141904 test-float-parse: apply cfg(not(bootstrap)) 6eaa27f0e03c526630e57b7372fd9943550547ff (link)

previous master: 449c801783

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 449c801 (parent) -> 5d707b0 (this PR)

Test differences

Show 260 test diffs

260 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5d707b07e42766c080c5012869c9988a18dcbb83 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 6546.8s -> 4609.7s (-29.6%)
  2. dist-apple-various: 6713.7s -> 5363.6s (-20.1%)
  3. x86_64-apple-2: 6204.1s -> 7129.2s (14.9%)
  4. dist-x86_64-apple: 11264.8s -> 12283.4s (9.0%)
  5. dist-aarch64-linux: 5398.3s -> 5831.4s (8.0%)
  6. x86_64-apple-1: 10879.8s -> 10080.0s (-7.4%)
  7. mingw-check-2: 2078.1s -> 2213.4s (6.5%)
  8. dist-x86_64-netbsd: 5385.8s -> 5067.4s (-5.9%)
  9. x86_64-msvc-1: 8105.3s -> 8550.4s (5.5%)
  10. x86_64-gnu-distcheck: 8234.2s -> 8642.9s (5.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Kobzol Kobzol deleted the rollup-wurlnsx branch June 3, 2025 05:19
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5d707b0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.1%, 0.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.7%, secondary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.9% [0.4%, 2.8%] 14
Improvements ✅
(primary)		 -1.7% [-1.7%, -1.7%] 2
Improvements ✅
(secondary)		 -0.5% [-0.5%, -0.5%] 2
All ❌✅ (primary) -1.7% [-1.7%, -1.7%] 2

Cycles

Results (secondary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.2% [0.4%, 4.8%] 12
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.6% [-0.9%, -0.4%] 6
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 744.828s -> 744.12s (-0.10%)
Artifact size: 372.28 MiB -> 372.22 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Kobzol @bors @rust-timer @rustbot @marcoieni @zacryol @Nadrieril @usamoi @jieyouxu