Skip to content

add f16_epsilon and f128_epsilon diagnostic items #141874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Jun 2, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 2, 2025
@tgross35
Copy link
Contributor

tgross35 commented Jun 2, 2025

These are only used in clippy, but it makes sense that we have them for these types too. Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit d948907 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
@tgross35 tgross35 changed the title add f16_epsilon and f128_epsilon add f16_epsilon and f128_epsilon diagnostic items Jun 2, 2025
@tgross35 tgross35 added the F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` label Jun 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 2, 2025
add f16_epsilon and f128_epsilon diagnostic items

cc rust-lang#116909
r? `@tgross35`
bors added a commit that referenced this pull request Jun 2, 2025
Rollup of 6 pull requests

Successful merges:

 - #140715 (Clarify &mut-methods' docs on sync::OnceLock)
 - #141309 (x86 (32/64): go back to passing SIMD vectors by-ptr)
 - #141677 (Async drop - type instead of async drop fn, fixes #140484)
 - #141733 (C-variadic functions must be unsafe)
 - #141858 (Fix typo in `StructuralPartialEq` docs)
 - #141874 (add f16_epsilon and f128_epsilon diagnostic items)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 2, 2025
Rollup of 5 pull requests

Successful merges:

 - #141767 (ci: use free runner for aarch64-gnu-llvm-19-1 PR job)
 - #141858 (Fix typo in `StructuralPartialEq` docs)
 - #141865 (Optionally don't steal the THIR)
 - #141874 (add f16_epsilon and f128_epsilon diagnostic items)
 - #141904 (test-float-parse: apply `cfg(not(bootstrap))`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b2743c7 into rust-lang:master Jun 2, 2025
9 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 2, 2025
rust-timer added a commit that referenced this pull request Jun 2, 2025
Rollup merge of #141874 - usamoi:eps, r=tgross35

add f16_epsilon and f128_epsilon diagnostic items

cc #116909
r? ``@tgross35``
@tgross35
Copy link
Contributor

tgross35 commented Jun 2, 2025

@usamoi are you also planning to do the clippy updates? If not, probably makes sense to open an issue there so these don't get lost

@usamoi
Copy link
Contributor Author

usamoi commented Jun 3, 2025

are you also planning to do the clippy updates?

yes

jieyouxu pushed a commit to jieyouxu/rustc-dev-guide that referenced this pull request Jun 3, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#141767 (ci: use free runner for aarch64-gnu-llvm-19-1 PR job)
 - rust-lang/rust#141858 (Fix typo in `StructuralPartialEq` docs)
 - rust-lang/rust#141865 (Optionally don't steal the THIR)
 - rust-lang/rust#141874 (add f16_epsilon and f128_epsilon diagnostic items)
 - rust-lang/rust#141904 (test-float-parse: apply `cfg(not(bootstrap))`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 4, 2025
add f16_epsilon and f128_epsilon diagnostic items

cc rust-lang#116909
r? ``@tgross35``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants