-
Notifications
You must be signed in to change notification settings - Fork 13.4k
tests/ui
: A New Order [2/N]
#141833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/ui
: A New Order [2/N]
#141833
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@@ -1,3 +1,5 @@ | |||
//! Tests bitwise operations with platform-specific and negative number behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: honestly, this test slightly confuses me because it doesn't seem to be covering all of the interesting boundary cases 🤔 Not for this PR tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: Huh, this test was from The Very Beginning (populate tree commit).
Can you squash the commits into one, drop the INFO in PR description? Looks good otherwise. |
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
@rustbot ready |
@bors r+ rollup |
Rollup of 8 pull requests Successful merges: - #141724 (fix(#141141): When expanding `PartialEq`, check equality of scalar types first.) - #141833 (`tests/ui`: A New Order [2/N]) - #141861 (Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images) - #141914 (redesign stage 0 std follow-ups) - #141918 (Deconstruct values in the THIR visitor) - #141923 (Update books) - #141931 (Deconstruct values in the THIR visitor) - #141956 (Remove two trait methods from cg_ssa) r? `@ghost` `@rustbot` modify labels: rollup
part of #133895
r? @jieyouxu
let's try this kind of commits, one for each file, commit's name shows what i did, hope this is not harder to review than previous