jsondocck: Refactor directive handling #141709
Open
+251
−238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-rustdoc-json
aDotInTheVoid
added
the
C-cleanup
GuillaumeGomez
changed the title
| /// `//@ !has <path>` | ||
| /// | ||
| /// Checks the path doesn't exist. | ||
| HasNotPath, |
There was a problem hiding this comment.
It sounds a bit weird to me, needed to read the docs (yeay docs!) to get what it was about. Also, is it really worth it to have two variants for each command and its opposite? Why not having a not: bool argument (or field directly in the enum if you prefer?) instead?
| _ => panic!("`//@ !has` must have 2 or 3 arguments, but got {args:?}"), | ||
| }, | ||
|
|
||
| (_, false) if KNOWN_DIRECTIVE_NAMES.contains(&directive_name) => { |
There was a problem hiding this comment.
Shouldn't it fail here saying it doesn't support the not mode for this command?
There was a problem hiding this comment.
What do you mean? This is for things that arn't negeated (e.g. //@ only-aarch64), which we should silently ignore. For //@ !only-aarch64, then negated will be true, this case won't match, and we'll panic the the wildcard below.
rust-cloud-vms
bot
force-pushed
the
split-for-docs
branch
from
7f54d30 to
508479d
Compare
rust-cloud-vms
bot
force-pushed
the
split-for-docs
branch
from
508479d to
14db1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit.
r? @GuillaumeGomez