Skip to content

[PERF] Revert "Auto merge of #141372 - khuey:ir_call_dbg_loc, r=jieyouxu" #141653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jieyouxu
Copy link
Member

This reverts commit 5e16c66, reversing changes made to 038d599.

r? @ghost

…youxu"

This reverts commit 5e16c66, reversing
changes made to 038d599.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 27, 2025
@jieyouxu
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 27, 2025
bors added a commit that referenced this pull request May 27, 2025
[PERF] Revert "Auto merge of #141372 - khuey:ir_call_dbg_loc, r=jieyouxu"

This reverts commit 5e16c66, reversing changes made to 038d599.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented May 27, 2025

⌛ Trying commit 8ae8071 with merge bf8a004...

@bors
Copy link
Collaborator

bors commented May 27, 2025

☀️ Try build successful - checks-actions
Build commit: bf8a004 (bf8a004815a4cd78172129fd3a48ed5912e8c913)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bf8a004): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
-0.2% [-0.4%, -0.1%] 48
Improvements ✅
(secondary)
-0.4% [-2.9%, -0.0%] 39
All ❌✅ (primary) -0.1% [-0.4%, 3.0%] 49

Max RSS (memory usage)

Results (secondary 5.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.8% [2.0%, 9.6%] 10
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.7%, secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-3.9%, -2.3%] 3
All ❌✅ (primary) 2.7% [2.7%, 2.7%] 1

Binary size

Results (primary 0.0%, secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.1%, -0.0%] 17
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 10
All ❌✅ (primary) 0.0% [-0.1%, 1.1%] 18

Bootstrap: 780.158s -> 780.629s (0.06%)
Artifact size: 366.33 MiB -> 366.41 MiB (0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 28, 2025
@jieyouxu jieyouxu closed this May 29, 2025
@jieyouxu jieyouxu deleted the revert-dbg-loc branch May 29, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants