Note the version and PR of removed features when using it #141642

xizheyin · 2025-05-27T09:35:14Z

I added the diagnostic information. Since all the current version information is present, it prints the version information anyway, as shown in tests/ui. And PR will not print if it is None, we can gradually add the PR links.

Split into two commits for easier review.

r? compiler

cc @jyn514 Since you're on vocation in the review list, I can't r? you.

tests/ui/deprecation/deprecated_no_stack_check.stderr

jieyouxu · 2025-05-27T11:29:23Z

r? compiler (bandwidth)

jyn514

thank you! this looks very good, i just have one comment about the new macro :)

compiler/rustc_feature/src/removed.rs

xizheyin · 2025-05-27T14:02:42Z

I tried opt_nonzero_u32!($($pull)?),, but it reports

error[E0015]: cannot call non-const method `std::option::Option::<NonZero<u32>>::or` in statics

So, I use helper macros to parse pull.

jyn514 · 2025-05-27T14:22:04Z

gotcha - can you write out the match explicitly instead of using or? i do think for this file specifically that having an accurate git blame is helpful.

separately i will open an issue to make or const, there's no reason for it not to be.

chenyukang · 2025-05-27T14:49:14Z

compiler/rustc_expand/src/config.rs

                sess.dcx().emit_err(FeatureRemoved {
-                    span: mi.span(),
-                    reason: f.reason.map(|reason| FeatureRemovedReason { reason }),
+                    span,


nit: seems the shorthand style here has more lines of code.

Thanks for the reminder, indeed.

xizheyin

can you write out the match explicitly instead of using or?

My current approach should have accomplished the goal?

xizheyin · 2025-05-27T16:43:58Z

compiler/rustc_feature/src/removed.rs

+macro_rules! opt_nonzero_u32 {
+    () => {
+        None
+    };
+    ($val:expr) => {
+        Some(NonZeroU32::new($val).unwrap())
+    };


I used an auxiliary macro to get around this to make sure the git blame doesn't get broken.

compiler/rustc_feature/src/removed.rs

tests/ui/deprecation/deprecated_no_stack_check.rs

xizheyin · 2025-06-04T09:14:57Z

I push the third commits to make since of removed features the version in which it was removed and fill pull.

I find the corresponding PR by going through all the features in removed.rs one by one and checking their corresponding git blame. if I don't have a query because it's too old, I search for keywords in PR in rust-lang/rust. The vast majority of them found the corresponding PRs, so please reviewers review them when you have time.

If there's nothing wrong with this PR, #141619 will be closed when it is merged.

xizheyin · 2025-06-07T06:46:06Z

r? compiler

xizheyin · 2025-06-07T06:47:28Z

wesleywiser may not have time as he put off another PR review yesterday.
r? compiler

bors · 2025-06-09T06:13:03Z

☔ The latest upstream changes (presumably #142220) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

BoxyUwU · 2025-06-10T04:34:03Z

@bors r+

I didn't really check that all the PR numbers associated with removed features are correct because that seems so incredibly mind numbingly tedious, and the cost of getting this wrong is extremely small.

bors · 2025-06-10T04:34:06Z

📌 Commit 4b89804 has been approved by BoxyUwU

It is now in the queue for this repository.

xizheyin · 2025-06-10T06:01:21Z

Yes, it took me hours to go through all the features. It's really boring. :)

BoxyUwU · 2025-06-10T07:49:56Z

Thank you for doing that work :3

Note the version and PR of removed features when using it Fixes rust-lang#141619 I added the diagnostic information. Since all the current version information is present, it prints the version information anyway, as shown in tests/ui. And PR will not print if it is None, we can gradually add the PR links. Split into two commits for easier review. r? compiler cc `@jyn514` Since you're on vocation in the review list, I can't r? you.

Rollup of 14 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141642 (Note the version and PR of removed features when using it) - #141909 (Add central execution context to bootstrap) - #141992 (use `#[naked]` for `__rust_probestack`) - #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods) - #142124 (Allow transmute casts in pre-runtime-MIR) - #142240 (deduplicate the rest of AST walker functions) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142271 (compiler: fn ptrs should hit different lints based on ABI) - #142288 (const_eval: fix some outdated comments) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 16 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141642 (Note the version and PR of removed features when using it) - #141818 (Don't create .msi installer for gnullvm hosts) - #141909 (Add central execution context to bootstrap) - #141992 (use `#[naked]` for `__rust_probestack`) - #142101 (core::ptr: deduplicate more method docs) - #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods) - #142124 (Allow transmute casts in pre-runtime-MIR) - #142240 (deduplicate the rest of AST walker functions) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142271 (compiler: fn ptrs should hit different lints based on ABI) - #142275 (rustdoc: Refractor `clean_ty_generics`) - #142288 (const_eval: fix some outdated comments) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141642 - xizheyin:issue-141619, r=BoxyUwU Note the version and PR of removed features when using it Fixes #141619 I added the diagnostic information. Since all the current version information is present, it prints the version information anyway, as shown in tests/ui. And PR will not print if it is None, we can gradually add the PR links. Split into two commits for easier review. r? compiler cc ``@jyn514`` Since you're on vocation in the review list, I can't r? you.

rustbot assigned jieyouxu May 27, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 27, 2025

xizheyin changed the title ~~Issue~~ Note the version and PR of removed features when using it May 27, 2025

xizheyin mentioned this pull request May 27, 2025

track the version and PR in which a nightly feature was removed #141619

Closed

This comment has been minimized.

Sign in to view

mejrs reviewed May 27, 2025

View reviewed changes

tests/ui/deprecation/deprecated_no_stack_check.stderr Outdated Show resolved Hide resolved

rustbot assigned lcnr and unassigned jieyouxu May 27, 2025

jyn514 approved these changes May 27, 2025

View reviewed changes

compiler/rustc_feature/src/removed.rs Outdated Show resolved Hide resolved

xizheyin force-pushed the issue-141619 branch from 0a542e3 to dc2d7f6 Compare May 27, 2025 13:55

This comment has been minimized.

Sign in to view

chenyukang reviewed May 27, 2025

View reviewed changes

xizheyin force-pushed the issue-141619 branch from dc2d7f6 to 5e02212 Compare May 27, 2025 16:40

xizheyin commented May 27, 2025

View reviewed changes

jyn514 reviewed May 27, 2025

View reviewed changes

compiler/rustc_feature/src/removed.rs Show resolved Hide resolved

tests/ui/deprecation/deprecated_no_stack_check.rs Outdated Show resolved Hide resolved

xizheyin force-pushed the issue-141619 branch from 5e02212 to b194255 Compare May 28, 2025 05:18

jyn514 approved these changes May 28, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

xizheyin force-pushed the issue-141619 branch from e2ffc11 to fa8c35d Compare June 4, 2025 10:10

rustbot assigned wesleywiser and unassigned lcnr Jun 7, 2025

rustbot assigned BoxyUwU and unassigned wesleywiser Jun 7, 2025

xizheyin added 3 commits June 9, 2025 17:10

Add ui test removed-features-note-version-and-pr-issue-141619

c2986ee

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

Note the version and PR of removed features when using it

b4ba017

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

Make since of removed features the version removed and fill pull

4b89804

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

xizheyin force-pushed the issue-141619 branch from fa8c35d to 4b89804 Compare June 9, 2025 09:18

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025

fmease mentioned this pull request Jun 10, 2025

Rollup of 14 pull requests #142290

Closed

fmease mentioned this pull request Jun 10, 2025

Rollup of 16 pull requests #142299

Merged

bors merged commit 2aea4b2 into rust-lang:master Jun 10, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 10, 2025

Note the version and PR of removed features when using it #141642

Note the version and PR of removed features when using it #141642

Uh oh!

Conversation

xizheyin commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

jieyouxu commented May 27, 2025

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xizheyin commented May 27, 2025

Uh oh!

This comment has been minimized.

jyn514 commented May 27, 2025

Uh oh!

chenyukang May 27, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin May 27, 2025

Choose a reason for hiding this comment

Uh oh!

xizheyin left a comment

Choose a reason for hiding this comment

Uh oh!

xizheyin May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xizheyin commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

xizheyin commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xizheyin commented Jun 7, 2025

Uh oh!

bors commented Jun 9, 2025

Uh oh!

BoxyUwU commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

xizheyin commented Jun 10, 2025

Uh oh!

BoxyUwU commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

xizheyin commented May 27, 2025 •

edited

Loading

xizheyin commented Jun 4, 2025 •

edited

Loading

xizheyin commented Jun 7, 2025 •

edited

Loading