Skip to content

ci: use ghcr registry for x86_64-gnu-tools job #141641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

marcoieni
Copy link
Member

Since this job runs in codebuild, we need to use ghcr.io.

r? @Kobzol

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 27, 2025
@Kobzol
Copy link
Contributor

Kobzol commented May 27, 2025

@bors r+ p=9

Some automation for checking this could be useful.

@bors
Copy link
Collaborator

bors commented May 27, 2025

📌 Commit 7314994 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2025
@bors
Copy link
Collaborator

bors commented May 27, 2025

⌛ Testing commit 7314994 with merge 642e49b...

@bors
Copy link
Collaborator

bors commented May 27, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 642e49b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 27, 2025
@bors bors merged commit 642e49b into rust-lang:master May 27, 2025
8 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 27, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0fc6f16 (parent) -> 642e49b (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 642e49bfed2481e54e252732be20d3c24cbec9e8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 7782.0s -> 5649.3s (-27.4%)
  2. dist-x86_64-apple: 9419.9s -> 7026.5s (-25.4%)
  3. aarch64-gnu: 6601.3s -> 7878.2s (19.3%)
  4. aarch64-gnu-debug: 4626.9s -> 4064.5s (-12.2%)
  5. x86_64-gnu-llvm-19-3: 6981.0s -> 7420.5s (6.3%)
  6. x86_64-gnu-distcheck: 8424.1s -> 8912.7s (5.8%)
  7. dist-apple-various: 6494.5s -> 6829.4s (5.2%)
  8. dist-android: 2531.6s -> 2659.1s (5.0%)
  9. x86_64-gnu-llvm-19-2: 5959.1s -> 6255.3s (5.0%)
  10. x86_64-apple-1: 7349.1s -> 7047.4s (-4.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (642e49b): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.0% [3.0%, 3.0%] 1

Max RSS (memory usage)

Results (primary -1.8%, secondary -3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.8% [-3.2%, -0.9%] 6
Improvements ✅
(secondary)
-3.0% [-7.5%, -1.2%] 24
All ❌✅ (primary) -1.8% [-3.2%, -0.9%] 6

Cycles

Results (primary 2.7%, secondary 7.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
7.8% [7.8%, 7.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.7% [2.7%, 2.7%] 1

Binary size

Results (primary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Bootstrap: 780.158s -> 780.121s (-0.00%)
Artifact size: 366.33 MiB -> 366.40 MiB (0.02%)

@rustbot rustbot added the perf-regression Performance regression. label May 27, 2025
@Kobzol
Copy link
Contributor

Kobzol commented May 27, 2025

Noise.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label May 27, 2025
@lqd
Copy link
Member

lqd commented May 27, 2025

These spikes actually having a 0.36% noise threshold is causing these issues.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants