Skip to content

Delegate <CStr as Debug> to ByteStr #141491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Conversation

tamird
Copy link
Contributor

@tamird tamird commented May 24, 2025

This allows UTF-8 characters to be printed without escapes, rather than
just ASCII.

r? @joshtriplett

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 24, 2025
@tamird tamird force-pushed the cstr-debug-bstr branch from dca5eb6 to 4f9972b Compare May 29, 2025 12:43
This allows UTF-8 characters to be printed without escapes, rather than
just ASCII.
@tamird tamird force-pushed the cstr-debug-bstr branch from 4f9972b to a820620 Compare June 12, 2025 17:08
@joshtriplett
Copy link
Member

Looks reasonable to me. r=me once CI passes.

@joshtriplett
Copy link
Member

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jun 12, 2025

✌️ @tamird, you can now approve this pull request!

If @joshtriplett told you to "r=me" after making some further change, please make that change, then do @bors r=@joshtriplett

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[TIMING] core::build_steps::test::Crate { compiler: Compiler { stage: 1, host: x86_64-unknown-linux-gnu, forced_compiler: true }, target: x86_64-unknown-linux-gnu, mode: Std, crates: ["std"] } -- 71.150
Build completed successfully in 0:01:15
+ head -n 1 /tmp/browser-ui-test.version
+ npm install browser-ui-test@0.20.6 --unsafe-perm=true
npm ERR! code 1
npm ERR! path /checkout/obj/node_modules/puppeteer
npm ERR! command failed
npm ERR! command sh -c node install.mjs
npm ERR! Chrome (127.0.6533.88) downloaded to /root/.cache/puppeteer/chrome/linux-127.0.6533.88
npm ERR! Error: ERROR: Failed to set up chrome-headless-shell v127.0.6533.88! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
npm ERR!     at file:///checkout/obj/node_modules/puppeteer/lib/esm/puppeteer/node/install.js:84:27
npm ERR!     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
npm ERR!     at async Promise.all (index 1)
npm ERR!     at async downloadBrowser (file:///checkout/obj/node_modules/puppeteer/lib/esm/puppeteer/node/install.js:90:9) {
npm ERR!   [cause]: Error: Download failed: server returned code 500. URL: https://storage.googleapis.com/chrome-for-testing-public/127.0.6533.88/linux64/chrome-headless-shell-linux64.zip
npm ERR!       at file:///checkout/obj/node_modules/@puppeteer/browsers/lib/esm/httpUtil.js:67:31
npm ERR!       at ClientRequest.requestCallback (file:///checkout/obj/node_modules/@puppeteer/browsers/lib/esm/httpUtil.js:45:13)
npm ERR!       at Object.onceWrapper (node:events:633:26)
npm ERR!       at ClientRequest.emit (node:events:518:28)
npm ERR!       at HTTPParser.parserOnIncomingClient (node:_http_client:698:27)
npm ERR!       at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
npm ERR!       at TLSSocket.socketOnData (node:_http_client:540:22)
npm ERR!       at TLSSocket.emit (node:events:518:28)
npm ERR!       at addChunk (node:internal/streams/readable:559:12)
npm ERR!       at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
npm ERR! }

npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2025-06-12T18_02_46_889Z-debug-0.log
  local time: Thu Jun 12 18:03:01 UTC 2025
  network time: Thu, 12 Jun 2025 18:03:01 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@tamird
Copy link
Contributor Author

tamird commented Jun 12, 2025

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025
@tamird
Copy link
Contributor Author

tamird commented Jun 12, 2025

Something's up with gnu-tools but not caused by this PR and I ran the tests locally so

@bors r=@joshtriplett

@bors
Copy link
Collaborator

bors commented Jun 12, 2025

📌 Commit a820620 has been approved by joshtriplett

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jun 13, 2025
Rollup of 10 pull requests

Successful merges:

 - #134847 (Implement asymmetrical precedence for closures and jumps)
 - #141491 (Delegate `<CStr as Debug>` to `ByteStr`)
 - #141770 (Merge `Cfg::render_long_html` and `Cfg::render_long_plain` methods common code)
 - #142069 (Introduce `-Zmacro-stats`)
 - #142158 (Tracking the old name of renamed unstable library features)
 - #142221 ([AIX] strip underlying xcoff object)
 - #142340 (miri: we can use apfloat's mul_add now)
 - #142379 (Add bootstrap option to compile a tool with features)
 - #142410 (intrinsics: rename min_align_of to align_of)
 - #142413 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8ae8989 into rust-lang:master Jun 13, 2025
7 of 10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 13, 2025
rust-timer added a commit that referenced this pull request Jun 13, 2025
Rollup merge of #141491 - tamird:cstr-debug-bstr, r=joshtriplett

Delegate `<CStr as Debug>` to `ByteStr`

This allows UTF-8 characters to be printed without escapes, rather than
just ASCII.

r? `@joshtriplett`
@tamird tamird deleted the cstr-debug-bstr branch June 13, 2025 15:07
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 14, 2025
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#134847 (Implement asymmetrical precedence for closures and jumps)
 - rust-lang/rust#141491 (Delegate `<CStr as Debug>` to `ByteStr`)
 - rust-lang/rust#141770 (Merge `Cfg::render_long_html` and `Cfg::render_long_plain` methods common code)
 - rust-lang/rust#142069 (Introduce `-Zmacro-stats`)
 - rust-lang/rust#142158 (Tracking the old name of renamed unstable library features)
 - rust-lang/rust#142221 ([AIX] strip underlying xcoff object)
 - rust-lang/rust#142340 (miri: we can use apfloat's mul_add now)
 - rust-lang/rust#142379 (Add bootstrap option to compile a tool with features)
 - rust-lang/rust#142410 (intrinsics: rename min_align_of to align_of)
 - rust-lang/rust#142413 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants