Path::with_extension: show that it adds an extension where one did no…

[tshepang]

…t exist

I think the times I encountered this, I had to check first if files without extensions were added, since all examples only had files with existing extensions.

Also, this replaced example already has a similar example below.

[rustbot]

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[lolbinarycat]

I think it would also make sense to show what the output of with_extension("") is, since that's done in the example but only as a round-trip, not actually showing its output.

also, you say there's already a "similar" example, but the .tar.gz example is there to show the case of multiple extensions, while the .rs example is there to show the base case.

if any example is redundant, i think it would be the .tar.xz example, but we could also just add an example without removing anything.

(disclaimer: not part of t-libs)

[ChrisDenton]

I like adding an example for the no extension case but I would agree that replacing the existing example isn't the way to do it. Having three examples seems fine (maybe with a brief comment pointing out what it's showing).

Personally I'd be minded to split this into two separate code blocks as the multiple extension case is a little more involved than the simpler cases. But I don't feel strongly about that.

[tshepang]

added commit to reduce visual noise... happy to remove if relying on type coercion is not ideal

[ChrisDenton]

Thanks!

@bors r+ rollup

[bors]

📌 Commit 248f4b2 has been approved by ChrisDenton

It is now in the queue for this repository.