Skip to content

Improve CONTRIBUTING.md grammar and clarity #141444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve CONTRIBUTING.md grammar and clarity #141444

wants to merge 1 commit into from

Conversation

zzzzzz8403
Copy link

slight grammar changes for clarity

@rustbot
Copy link
Collaborator

rustbot commented May 23, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2025
Noratrieb
Noratrieb reviewed May 23, 2025
View reviewed changes
@Noratrieb
Copy link
Member

Thanks, can you squash the two commits together? I can merge it afterwards

@zzzzzz8403
Copy link
Author

im not using the command line version so i just created a 3rd commit with all the changes and im going to delete the other commits

@zzzzzz8403
Copy link
Author

i have no idea how to merge without the command line and i have litteraly no clue how to use the command line

@Noratrieb
Copy link
Member

That works too. If you need any help with it, I can do it for you as well.

@zzzzzz8403
Copy link
Author

zzzzzz8403 commented May 23, 2025 •
edited
Loading

this git interface is way too confusing if you could do it that would be very nice please thanks, i could also just make a completley new pull request then close this one if you want.

@zzzzzz8403 @Noratrieb
Improve CONTRIBUTING.md grammar and clarity
25c7591 
slight grammar changes for clarity
@Noratrieb
Copy link
Member

I deleted your last commit and squashed the first two. Thank you for the PR!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 23, 2025

📌 Commit 25c7591 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#141444 - zzzzzz8403:patch-1, r=Noratrieb
46b4241 
Improve CONTRIBUTING.md grammar and clarity

slight grammar changes for clarity
@matthiaskrgr matthiaskrgr mentioned this pull request May 23, 2025
Open
bors added a commit that referenced this pull request May 24, 2025
@bors
Auto merge of #141473 - matthiaskrgr:rollup-y3vhivo, r=matthiaskrgr
8b9fb9f 
Rollup of 8 pull requests

Successful merges:

 - #140790 (Enable xray support for Mac)
 - #141405 (GetUserProfileDirectoryW is now documented to always store the size)
 - #141413 (Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING)
 - #141427 (Disable `triagebot`'s `glacier` handler)
 - #141429 (Dont walk into unsafe binders when emiting error for non-structural type match)
 - #141438 (Do not try to confirm non-dyn compatible method)
 - #141444 (Improve CONTRIBUTING.md grammar and clarity)
 - #141446 (Add 2nd Solaris target maintainer)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zzzzzz8403 @rustbot @Noratrieb @bors @Mark-Simulacrum