ci: convert distcheck to free runner #141382
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
FWIW, 2h 35m is not so terrible and I wouldn't mind landing that, we definitely have slower runners now. |
|
mmm yes, but what's the con of having a faster job? 🚀 |
|
x64 is still way more popular than aarch64, so having distcheck coverage for that seems a bit more important. But I don't mind that much, just wanted to see if a free runner is also a viable alternative here. |
|
I see. Makes sense. I have almost no preference. Let's see how the try job goes. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2025
ci: convert distcheck to free runner try-job: x86_64-gnu-distcheck
|
☀️ Try build successful - checks-actions |
|
2h 24m. I would just land it like this, to keep the original behavior. |
rustbot
added
the
S-waiting-on-review
|
makes sense. If it becomes too slow in the future, we can always switch to the arm runner. |
This was referenced May 22, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#141355 (ci: improve citool job db errors) - rust-lang#141359 (Fix `FnOnce` impl for `AsyncFn`/`AsyncFnMut` self-borrowing closures in new solver) - rust-lang#141362 (Normalize aliases to correct kind of error term) - rust-lang#141377 (Remove unnecessary `is_empty` checks) - rust-lang#141381 (try_cast_aligned: avoid bare int-to-ptr casts) - rust-lang#141382 (ci: convert distcheck to free runner) - rust-lang#141389 (ci: prepare aws access keys for migration) - rust-lang#141390 (Don't allow `poly_select` in new solver) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2025
Rollup merge of rust-lang#141382 - marcoieni:distcheck-free-x86, r=Kobzol ci: convert distcheck to free runner try-job: x86_64-gnu-distcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to free runner to make CI more efficient.
r? @ghost
try-job: x86_64-gnu-distcheck