rustdoc-json: Remove false docs and add test for inline attribute #141364
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs about how `#[inline]` was represented isn't true. Updates the comment, and adds a test. CC https://www.github.com/rust-lang/rust/issues/137645
rustbot
added
A-rustdoc-json
|
These commits modify Please ensure that if you've changed the output:
cc @aDotInTheVoid, @obi1kenobi rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing |
GuillaumeGomez
approved these changes
May 21, 2025
|
Thanks! r=me once CI pass |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#140431 (dont handle bool transmute) - rust-lang#140868 (rustdoc: Fix links with inline code in trait impl docs) - rust-lang#141323 (Add bors environment to CI) - rust-lang#141337 (bump stdarch) - rust-lang#141364 (rustdoc-json: Remove false docs and add test for inline attribute) - rust-lang#141370 (add doc alias `replace_first` for `str::replacen`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2025
Rollup merge of rust-lang#141364 - aDotInTheVoid:atttrdocss, r=GuillaumeGomez rustdoc-json: Remove false docs and add test for inline attribute The docs about how `#[inline]` was represented isn't true. Updates the comment, and adds a test. CC rust-lang#137645 r? `@GuillaumeGomez`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs about how
#[inline]was represented isn't true. Updates the comment, and adds a test.CC #137645
r? @GuillaumeGomez