Async drop fix for 'broken mir, place has deref as later projection' #141296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
azhogin
force-pushed
the
azhogin/async-drop-broken-mir-place-deref-fix
branch
from
14a9dd6 to
f8ae5e9
Compare
This comment has been minimized.
This comment has been minimized.
|
if you write |
azhogin
force-pushed
the
azhogin/async-drop-broken-mir-place-deref-fix
branch
from
f8ae5e9 to
f7afa6f
Compare
oli-obk
reviewed
May 20, 2025
… later projection' (rust-lang#140975)
azhogin
force-pushed
the
azhogin/async-drop-broken-mir-place-deref-fix
branch
from
f7afa6f to
7c38b6f
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 21, 2025
…mir-place-deref-fix, r=oli-obk Async drop fix for 'broken mir, place has deref as later projection' fixes rust-lang#140975 Problem in codegen fixed with an additional temporary local.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#141267 (only resolve top-level guard patterns' guards once) - rust-lang#141280 (Use Docker cache from the current repository) - rust-lang#141296 (Async drop fix for 'broken mir, place has deref as later projection') - rust-lang#141328 (When AsyncDrop impl is empty, sync drop generated in elaborator) - rust-lang#141332 (Do not eagerly fold consts in `normalize_param_env_or_error` if new solver) - rust-lang#141333 (Use `DeepRejectCtxt` in `assemble_inherent_candidates_from_param`) - rust-lang#141334 (eagerly check nested obligations when coercing fndefs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #140975
Problem in codegen fixed with an additional temporary local.