Skip to content

Querify coroutine_hidden_types #141286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Querify coroutine_hidden_types #141286

merged 1 commit into from
May 23, 2025
+67 −41

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented May 20, 2025 •
edited
Loading

This is necessary if we ever want to add implied bounds that would be used for higher-ranked coroutine auto trait goals (e.g. future implements Send).

Modest perf regression in hyper full build which (afaict?) is the only async stress test, so definitely worth it IMO.

r? oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 20, 2025
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 20, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
@bors
Auto merge of rust-lang#141286 - compiler-errors:querify-coroutine, r…
7608881 
…=<try>

Querify `coroutine_hidden_types`

r? `@ghost`
@bors
Copy link
Collaborator

bors commented May 20, 2025

⌛ Trying commit 2f28598 with merge 7608881...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 20, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2025
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 20, 2025

⌛ Trying commit 6555ef7 with merge 34f8162...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
@bors
Auto merge of rust-lang#141286 - compiler-errors:querify-coroutine, r…
34f8162 
…=<try>

Querify `coroutine_hidden_types`

r? `@ghost`
@bors
Copy link
Collaborator

bors commented May 20, 2025

☀️ Try build successful - checks-actions
Build commit: 34f8162 (34f8162c904adfe2aff1d76ebcc56268c8376545)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (34f8162): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 0.7% [0.3%, 1.1%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.3%, 1.1%] 2

Max RSS (memory usage)

Results (primary 1.3%, secondary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.5% [4.5%, 4.5%] 1
Regressions ❌
(secondary)		 7.5% [7.5%, 7.5%] 1
Improvements ✅
(primary)		 -2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)		 -2.8% [-5.1%, -0.4%] 2
All ❌✅ (primary) 1.3% [-2.0%, 4.5%] 2

Cycles

Results (secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.8% [0.4%, 1.1%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.6% [-0.8%, -0.4%] 6
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.927s -> 777.132s (0.16%)
Artifact size: 365.55 MiB -> 365.40 MiB (-0.04%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 20, 2025
@compiler-errors
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2025
@oli-obk
Copy link
Contributor

oli-obk commented May 22, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 22, 2025

📌 Commit 6555ef7 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2025
@oli-obk
Copy link
Contributor

oli-obk commented May 22, 2025

@bors rollup

both "regressions" are actually unrelated noise

@matthiaskrgr matthiaskrgr mentioned this pull request May 22, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2025
@bors
Auto merge of rust-lang#141396 - matthiaskrgr:rollup-feg050g, r=matth…
912981a 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135562 (Add ignore value suggestion in closure body)
 - rust-lang#139635 (Finalize repeat expr inference behaviour with inferred repeat counts)
 - rust-lang#139668 (Handle regions equivalent to 'static in non_local_bounds)
 - rust-lang#140218 (HIR ty lowering: Clean up & refactor the lowering of type-relative paths)
 - rust-lang#140435 (use uX::from instead of _ as uX in non - const contexts)
 - rust-lang#141130 (rustc_on_unimplemented cleanups)
 - rust-lang#141286 (Querify `coroutine_hidden_types`)

Failed merges:

 - rust-lang#140247 (Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8c25082 into rust-lang:master May 23, 2025
7 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2025
@rust-timer
Unrolled build for rust-lang#141286
2a3e471 
Rollup merge of rust-lang#141286 - compiler-errors:querify-coroutine, r=oli-obk

Querify `coroutine_hidden_types`

This is necessary if we ever want to add implied bounds that would be used for higher-ranked coroutine auto trait goals (e.g. future implements `Send`).

Modest perf regression in `hyper` full build which (afaict?) is the only async stress test, so definitely worth it IMO.

r? oli-obk
@rustbot rustbot added this to the 1.89.0 milestone May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rust-timer @bors @rust-log-analyzer @oli-obk @rustbot