Skip to content

Conversation

@the8472
Copy link
Member

@the8472 the8472 commented May 11, 2025

Assembly test for #140207

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2025
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 11, 2025

📌 Commit 6326300 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2025
@bors
Copy link
Collaborator

bors commented May 12, 2025

⌛ Testing commit 6326300 with merge ac9ac0e...

@bors
Copy link
Collaborator

bors commented May 12, 2025

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing ac9ac0e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 12, 2025
@bors bors merged commit ac9ac0e into rust-lang:master May 12, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 12, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 718ddf6 (parent) -> ac9ac0e (this PR)

Test differences

Show 33153 test diffs

Stage 1

  • ascii::test_eq_ignore_ascii_case: pass -> [missing] (J0)
  • asserting::capture_with_non_debuggable_elem_has_correct_params: pass -> [missing] (J0)
  • bool::test_bool_to_option: pass -> [missing] (J0)
  • c_str2::cstr_const_constructor: pass -> [missing] (J0)
  • cmp::test_ordering_order: pass -> [missing] (J0)
  • collections::binary_heap::test_into_iter_collect: pass -> [missing] (J0)
  • collections::btree::map::tests::test_clear_drop_panic_leak: pass -> [missing] (J0)
  • collections::hash::map::tests::test_entry_take_doesnt_corrupt: pass -> [missing] (J0)
  • collections::hash::set::tests::test_extend_ref: pass -> [missing] (J0)
  • f64::test_is_infinite: pass -> [missing] (J0)
  • fmt::builders::debug_list::test_single: pass -> [missing] (J0)
  • fmt::num::test_format_int: pass -> [missing] (J0)
  • iter::adapters::intersperse::test_intersperse_size_hint: pass -> [missing] (J0)
  • iter::adapters::map_windows::output_n1: pass -> [missing] (J0)
  • mpsc::oneshot_multi_thread_recv_close_stress: pass -> [missing] (J0)
  • mutex::test_mapping_mapped_guard: pass -> [missing] (J0)
  • nonzero::nonzero_leading_zeros: pass -> [missing] (J0)
  • slice::test_mut_rchunks_0: pass -> [missing] (J0)
  • slice::test_rchunks_exact_last: pass -> [missing] (J0)
  • sync::test_cowarc_clone_weak: pass -> [missing] (J0)
  • thin_box::want_niche_optimization: pass -> [missing] (J0)
  • time::sub_bad2: pass -> [missing] (J0)
  • vec_deque::test_drop_clear: pass -> [missing] (J0)
  • sort::tests::unstable::correct_u64_random_s95: ignore -> [missing] (J1)
  • analyze_source_file::tests::non_narrow_short: pass -> [missing] (J2)
  • bit_set::tests::bench_remove: pass -> [missing] (J2)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_93: pass -> [missing] (J2)
  • errors::verify_interface_generated_file_conflicts_with_directory_8: pass -> [missing] (J2)
  • errors::verify_mir_build_non_empty_never_pattern_23: pass -> [missing] (J2)
  • errors::verify_pattern_analysis_excluside_range_missing_max_0: pass -> [missing] (J2)
  • graph::iterate::tests::diamond_post_order: pass -> [missing] (J2)
  • html::render::ordered_json::tests::escape_json_string_escaped_escaped: pass -> [missing] (J2)
  • lints::verify_lint_variant_size_differences_88: pass -> [missing] (J2)
  • session_diagnostics::verify_attr_parsing_unrecognized_repr_hint_32: pass -> [missing] (J2)
  • spec::tests::aarch64_unknown_nto_qnx710_iosock: pass -> [missing] (J2)
  • spec::tests::avr_none: pass -> [missing] (J2)
  • spec::tests::riscv32im_risc0_zkvm_elf: pass -> [missing] (J2)
  • spec::tests::thumbv7em_nuttx_eabihf: pass -> [missing] (J2)
  • spec::tests::wasm64_unknown_unknown: pass -> [missing] (J2)
  • tests::test_attr_macro: pass -> [missing] (J2)
  • transitive_relation::tests::mubs_best_choice_scc: pass -> [missing] (J2)
  • btree::set::clone_100_and_pop_all: pass -> [missing] (J3)
  • num::dec2flt::bench_0: pass -> [missing] (J3)
  • slice::rotate_rgb: pass -> [missing] (J3)
  • slice::starts_with_single_element: pass -> [missing] (J3)
  • sort::tests::stable::violate_ord_retain_orig_set_cell_i32_random: pass -> [missing] (J3)
  • sort::tests::unstable::deterministic_i32_descending: pass -> [missing] (J3)
  • sort::tests::unstable::observable_is_less_saw_mixed: pass -> [missing] (J3)
  • str::char_count::zh_huge::case03_manual_char_len: pass -> [missing] (J3)
  • string::bench_with_capacity: pass -> [missing] (J3)
  • task::test_waker_will_wake_clone: pass -> [missing] (J3)
  • vec::bench_dedup_all_10000: pass -> [missing] (J3)
  • vec::bench_in_place_xu32_0010_i1: pass -> [missing] (J3)

Stage 2

  • collections::binary_heap::test_iterator: [missing] -> pass (J0)
  • fmt::num::test_format_int: [missing] -> pass (J0)
  • io::cursor::tests::test_buf_reader: [missing] -> pass (J0)
  • io::stdio::tests::test_lock_stderr: [missing] -> pass (J0)
  • iter::adapters::map_windows::test_size_hint: [missing] -> pass (J0)
  • mpmc::shared_recv_timeout: [missing] -> pass (J0)
  • mpsc_sync::send3: [missing] -> pass (J0)
  • mpsc_sync::smoke: [missing] -> pass (J0)
  • net::ip_addr::ipv4_from_octets: [missing] -> pass (J0)
  • num::dec2flt::fast_path_correct: [missing] -> pass (J0)
  • num::f64::maximum: [missing] -> pass (J0)
  • num::i64::test_next_multiple_of: [missing] -> pass (J0)
  • pin_macro::rust_2024_expr: [missing] -> pass (J0)
  • str::test_bytesator_nth: [missing] -> pass (J0)
  • str::test_str_container: [missing] -> pass (J0)
  • string::test_extend_ref: [missing] -> pass (J0)
  • test_uint_from_str_overflow: [missing] -> pass (J0)
  • thread::tests::test_park_timeout_unpark_before: [missing] -> pass (J0)
  • vec::test_drain_end_overflow: [missing] -> pass (J0)
  • vec::test_into_iter_as_slice: [missing] -> pass (J0)
  • vec::test_zero_sized_capacity: [missing] -> pass (J0)
  • vec_deque::test_append: [missing] -> pass (J0)
  • sort::tests::unstable::panic_retain_orig_set_cell_i32_descending: [missing] -> ignore (J1)
  • sort::tests::unstable::panic_retain_orig_set_string_random_d2: [missing] -> ignore (J1)
  • sort::tests::unstable::self_cmp_string_ascending: [missing] -> ignore (J1)
  • edit_distance::tests::test_find_best_match_for_name: [missing] -> pass (J2)
  • errors::verify_ast_lowering_never_pattern_with_guard_28: [missing] -> pass (J2)
  • errors::verify_codegen_ssa_invalid_monomorphization_inserted_type_110: [missing] -> pass (J2)
  • errors::verify_expand_duplicate_matcher_binding_35: [missing] -> pass (J2)
  • errors::verify_expand_feature_not_allowed_19: [missing] -> pass (J2)
  • errors::verify_expand_var_still_repeating_4: [missing] -> pass (J2)
  • errors::verify_lint_builtin_ellipsis_inclusive_range_patterns_1: [missing] -> pass (J2)
  • errors::verify_metadata_import_name_type_raw_75: [missing] -> pass (J2)
  • errors::verify_trait_selection_rustc_on_unimplemented_empty_on_clause_10: [missing] -> pass (J2)
  • layout::tree::tests::prune::should_accept::visible_def: [missing] -> pass (J2)
  • lints::verify_lint_builtin_unsafe_block_7: [missing] -> pass (J2)
  • spec::tests::armv6_unknown_freebsd: [missing] -> pass (J2)
  • spec::tests::sparc_unknown_linux_gnu: [missing] -> pass (J2)
  • tests::bench_copy: [missing] -> pass (J2)
  • btree::map::clone_fat_val_100: [missing] -> pass (J3)
  • btree::map::iter_10k: [missing] -> pass (J3)
  • hash::map::get_remove_insert: [missing] -> pass (J3)
  • net::tcp::tests::debug: [missing] -> pass (J3)
  • num::dec2flt::bench_short_decimal: [missing] -> pass (J3)
  • slice::reverse_u16: [missing] -> pass (J3)
  • sort::tests::unstable::stability_string_saw_mixed: [missing] -> pass (J3)
  • os::unix::net::tests::test_send_vectored_fds_unix_stream: [missing] -> pass (J4)

(and 16507 additional test diffs)

Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ac9ac0e0f36dcd7f8a8f0405cd003585fe4e4426 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 4732.4s -> 1415.1s (-70.1%)
  2. test-various: 4138.7s -> 2313.9s (-44.1%)
  3. aarch64-apple: 4720.5s -> 3088.2s (-34.6%)
  4. x86_64-gnu-aux: 6035.5s -> 4081.7s (-32.4%)
  5. dist-x86_64-apple: 7967.5s -> 9333.1s (17.1%)
  6. dist-aarch64-apple: 4755.3s -> 5306.7s (11.6%)
  7. x86_64-mingw-2: 7528.2s -> 6863.4s (-8.8%)
  8. x86_64-apple-1: 6994.6s -> 6419.5s (-8.2%)
  9. dist-i686-mingw: 7862.7s -> 8445.9s (7.4%)
  10. dist-android: 2692.5s -> 2547.4s (-5.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ac9ac0e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Cycles

Results (primary 0.2%, secondary -7.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.5% [0.5%, 0.5%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)
-7.2% [-9.0%, -5.5%] 4
All ❌✅ (primary) 0.2% [-0.8%, 0.5%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.98s -> 772.356s (-0.08%)
Artifact size: 365.35 MiB -> 365.43 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants