[rustdoc] Ensure that temporary doctest folder is correctly removed even if doctests failed #140706
+31
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139899.
The bug was due to the fact that if any doctest fails for any reason, we call
exit
(or it's called insidelibtest
if not edition 2024), meaning thatTempDir
's destructor isn't called, and therefore the temporary folder isn't cleaned up.Took me a while to figure out how to reproduce but finally I was able to reproduce the bug with:
And then I ensured that panicking doctests were cleaned up as well:
And finally I checked if it was fixed for merged doctests too (
--edition 2024
).To make this work, I needed to add a new public function in
libtest
too which would call a function once all tests have been run.So only issue is: I have absolutely no idea how we can add a regression test for this fix. If anyone has an idea...
r? @notriddle