-
Notifications
You must be signed in to change notification settings - Fork 13.3k
build_helper: handle emails containing square brackets #140675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
japaric
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
ferrocene:ja/gh140669-stage0-square-brackets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
build_helper: handle emails containing square brackets #140675
japaric
wants to merge
1
commit into
rust-lang:master
from
ferrocene:ja/gh140669-stage0-square-brackets
+43
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `git` API shells out to `git rev-list` and was directly passing an email string to the command's `--author` flag. That flag interprets its arguments as a regular expression, meaning that characters like square brackets (`[]`) in the email string made the command fail to find a commit matching the author e-mail This commit escapes the email string prior to passing it to `git rev-list`. The change is tested in the `bootstrap` crate because it contains the testing infrastructure to create temporary git repositories. fixes rust-lang#140669
rustbot has assigned @Mark-Simulacrum. Use |
The job Click to see the possible cause of the failure (guessed by this bot)
|
r? @Kobzol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
git
API shells out togit rev-list
and was directly passing an email string to the command's--author
flag. That flag interprets its arguments as a regular expression, meaning that characters like square brackets ([]
) in the email string made the command fail to find a commit matching the author e-mailThis commit escapes the email string prior to passing it to
git rev-list
.The change is tested in the
bootstrap
crate because it contains the testing infrastructure to create temporary git repositories.fixes #140669