Skip to content

Parser: Recover error from named params while parse_path #140671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Parser: Recover error from named params while parse_path #140671

wants to merge 5 commits into from
+171 −59

Conversation

xizheyin
Copy link
Contributor

@xizheyin xizheyin commented May 5, 2025 •
edited
Loading

Fixes #140169

I added test to the first commit and the second added the code and changes to test.

r? @petrochenkov

@xizheyin
Add ui test fn-trait-use-named-params
896cf80 
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 5, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 5, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

xizheyin
xizheyin commented May 6, 2025
View reviewed changes
Copy link
Contributor Author

@xizheyin xizheyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 6, 2025
@xizheyin xizheyin changed the title Recover from Fn, FnOnce, FnMut trait with named params Parser: Recover error from named params while parse_path May 6, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@xizheyin
Recover from named params while parse_path
c643bb2 
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
petrochenkov
petrochenkov reviewed May 6, 2025
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2025
xizheyin and others added 2 commits May 6, 2025 18:31
@xizheyin @petrochenkov
Update compiler/rustc_parse/messages.ftl
3a76b34 
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
@xizheyin @petrochenkov
Update compiler/rustc_parse/messages.ftl
804c6b4 
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
@rust-log-analyzer

This comment has been minimized.

Sign in to view
xizheyin
xizheyin commented May 6, 2025
View reviewed changes
Copy link
Contributor Author

@xizheyin xizheyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 6, 2025
petrochenkov
petrochenkov reviewed May 6, 2025
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2025
@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 6, 2025
@xizheyin
Copy link
Contributor Author

xizheyin commented May 6, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 6, 2025
compiler-errors
compiler-errors requested changes May 6, 2025
View reviewed changes
@xizheyin
Add error for c_variadic and attribute in Trait(...) syntax
1c4b9ec 
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@compiler-errors compiler-errors compiler-errors requested changes

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fn(a: u8) should get a clear diagnostic
5 participants
@xizheyin @rust-log-analyzer @compiler-errors @rustbot @petrochenkov