Rollup of 10 pull requests #140529
Merged
Rollup of 10 pull requests #140529
+33,319
−39,602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was being used by a single assist, which qualifies under the "refactor" kind. The variant has been removed, and all usages updated accordingly. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
fix(ide-assists): remove `AssistKind::None`
…s-string Fix color brackets in string context
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
A Cargo project can now be built without any dependency metadata being fetched. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Implicit field references during struct initialization were being dropped because get_definition was returning None because there were multiple definitions. This adds a new helper, `get_defintions`, that supports returning more than one definition for a given token and hooks it up. Fixes rust-lang#19393
Align usage of `default` and `new` with style guide
fix: don't drop references with more than one definition.
…anic-in-view-crate-graph internal: fix panic in `view_crate_graph`
…alsafied-crate-graph-with-lazy-project-discovery internal: ensure a Salsa-ified crate graph works with project discovery
…deps feat(project-model): provide flag for no deps
The rustdoc file prefix for constants is "constant" not "const"
fix: Fix a bug in MBE expansion that arose from incorrect fixing of an older bug in MBE
add more completion about "impl"
fix: Fix `format_args` lowering for >=1.87
chore: Set up a proper job matrix for rust-cross
Upstream stdx changes
fix: Yet another false positive invalid cast diagnostic
chore: clean up some FIXMEs
Tidy up drop glue notification
Co-authored-by: est31 <est31@users.noreply.github.com>
I had trouble easily understanding what these various flags do. This is my attempt to try to explain what these do.
Subtree update of `rust-analyzer` r? ````@ghost````
…pped-tuple-ice, r=oli-obk Fix for async drop ice with partly dropped tuple Fixes rust-lang#140427. Problem was with block data access with block id from new added blocks in patch.
chore: edit and move tests I deleted `ui/non-copyable-void.rs`: added in rust-lang@ab4105d to test that "nonconstructable" enums are "noncopyable", but these properties are not correlated anymore. Second commit is kinda messy because I moved/edited/renamed some files at the same time, but I deleted nothing there.
Don't FCW assoc consts in patterns Fixes rust-lang#140447 See comment in added test. We could also check that the anon const is a const arg by looking at the HIR. I'm not sure that's necessary though 🤔 The only consts that are evaluated "for the type system" are const args (which *should* get FCWs) and const patterns (which cant be anon consts afaik).
… r=lcnr Minor tweaks to make some normalization (adjacent) code less confusing r? lcnr sorry for double ping lol
CI: rfl: move job forward to Linux v6.15-rc4 A hopefully routine upgrade to Linux v6.15-rc4! r? `````@lqd````` `````@Kobzol````` try-job: x86_64-rust-for-linux `````@rustbot````` label A-rust-for-linux `````@bors````` try
chore: delete unused ui/auxiliary crates It appears that all the tests that used it have been moved to tests/ui/editions/ (or elsewhere) already. r? `````@jieyouxu`````
Require sanitizers be enabled for asan_odr_windows.rs Issue Details: The `asan_odr_windows.rs` test is failing on AArch64 Windows, as sanitizers aren't supported on that platform. Fix Details: Apply the correct "need sanitizer" requirements to the test.
…bool-lit, r=calebcartwright rustfmt: Also allow bool literals as first item of let chain This is a functional cherry-pick of rust-lang/rustfmt#6492 I'm bringing this change over directly as the subtree sync is taking more effort than anticipated (some unrelated r-l/rustfmt changes need to be reverted before we perform the full sync) and we need to ensure that rustfmt behavior accounts with the final style guide rules as part of let chain stabilization. r? ````@ghost````
…viscross,SparrowLii Parser: Document restrictions I had trouble easily understanding what these various flags do. This is my attempt to try to explain what these do.
|
@bors r+ rollup=never p=5 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 251cda5 (parent) -> b45dd71 (this PR) Test differencesShow 25 test diffsStage 1
Stage 2
Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard b45dd71d1824f176fba88f6c40467030a16afa2c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 251cda5e1f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (b45dd71): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.3%, secondary 2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 1.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 769.968s -> 767.216s (-0.36%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rust-analyzer#140385 (Subtree update ofrust-analyzer)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup