bootstrap: Inhibit download-rustc in CI when tools are changed #140322
+38
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @albertlarsan68. Use |
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
Zalathar
force-pushed
the
download-rustc-tools
branch
from
9f355a3 to
b05be37
Compare
|
Like I said on the Zulip thread, I think the proper solution would be to investigate and fix the issue of "some tests being ignored" rather than excluding tool paths from ci-rustc. Those tools don't have any effect on the rustc builds. |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically avoids situations like #139998 (comment) and #140177 (comment), where a sensitive change to compiletest was eligible for download-rustc, preventing the collection of proper test metrics for comparison.
While the primary goal is to make compiletest changes inhibit download-rustc, this PR ends up making any change to
src/toolsinhibit download-rustc (but only in CI builds). With the current code, it's not clear how to “un-exempt” individual subdirectories that are covered by another exemption.See https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20tool.20changes.20inhibit.20download-rustc.20on.20CI.3F for associated discussion.