Skip to content

Rustdoc js scrape examples typecheck #140314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lolbinarycat
Copy link
Contributor

more typechecking progress, this time we're mostly held back by the fact that document.querySelectorAll can't return nice types if its given a compound query (see the issue linked in a code comment).

Additionally, it seems like the generated data-locs attribute has fields that are never used by anything?

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-js-scrape-examples-typecheck branch from a72ad4e to 25c6898 Compare April 25, 2025 22:08
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
          · error: SyntaxError: Unexpected token (130:69)
          · see the printed err.stack below for context
          ----

          SyntaxError: Unexpected token (130:69)
    at pp$4.raise (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:3656:15)
    at pp$9.unexpected (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:776:10)
    at pp$9.semicolon (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:753:68)
    at pp$8.parseVarStatement (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:1196:10)
    at pp$8.parseStatement (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:931:19)
    at pp$8.parseBlock (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:1264:23)
    at pp$5.parseFunctionBody (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:3471:24)
    at pp$8.parseFunction (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:1386:10)
    at pp$8.parseFunctionStatement (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:1080:17)
    at pp$8.parseStatement (/node/lib/node_modules/es-check/node_modules/acorn/dist/acorn.js:919:19)
        
  local time: Fri Apr 25 22:38:20 UTC 2025
  network time: Fri, 25 Apr 2025 22:38:20 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants