- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Rollup of 16 pull requests #138326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
                
     Closed
            
            Rollup of 16 pull requests #138326
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Currently, when enabling CFI via -Zsanitizer=cfi and executing e.g. std::sys::random::getrandom, we can observe a CFI violation. This is the case for all consumers of the std::sys::pal::weak::weak macro, as it is defining weak functions which don't show up in LLVM IR metadata. CFI fails for all these functions. Similar to other such cases in rust-lang#115199, this change stops emitting the CFI typecheck for consumers of the macro via the \#[no_sanitize(cfi)] attribute.
Just to avoid surprises, the amount of used keys is not large.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
| 
           Fast-rejection rollup.  | 
    
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Mar 11, 2025 
    
    
      
  
    
      
    
  
Rollup of 16 pull requests Successful merges: - rust-lang#126856 (remove deprecated tool `rls`) - rust-lang#136932 (Reduce formatting `width` and `precision` to 16 bits) - rust-lang#137314 (change definitely unproductive cycles to error) - rust-lang#137612 (Update bootstrap to edition 2024) - rust-lang#138002 (Disable CFI for weakly linked syscalls) - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test) - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs) - rust-lang#138109 (make precise capturing args in rustdoc Json typed) - rust-lang#138147 (Add maintainers for powerpc64le-unknown-linux-gnu) - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments) - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT) - rust-lang#138300 (add tracking issue for unqualified_local_imports) - rust-lang#138307 (Allow specifying glob patterns for try jobs) - rust-lang#138313 (Update books) - rust-lang#138315 (use next_back() instead of last() on DoubleEndedIterator) - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js) r? `@ghost` `@rustbot` modify labels: rollup
| 
           💔 Test failed - checks-actions  | 
    
| 
           Looking.  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-attributes
  Area: Attributes (`#[…]`, `#![…]`) 
  
    A-run-make
  Area: port run-make Makefiles to rmake.rs 
  
    A-rustc-dev-guide
  Area: rustc-dev-guide 
  
    A-rustdoc-json
  Area: Rustdoc JSON backend 
  
    A-rustdoc-search
  Area: Rustdoc's search feature 
  
    A-testsuite
  Area: The testsuite used to check the correctness of rustc 
  
    A-tidy
  Area: The tidy tool 
  
    O-unix
  Operating system: Unix-like 
  
    rollup
  A PR which is a rollup 
  
    S-waiting-on-author
  Status: This is awaiting some action (such as code changes or more information) from the author. 
  
    T-bootstrap
  Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  
    T-infra
  Relevant to the infrastructure team, which will review and decide on the PR/issue. 
  
    T-libs
  Relevant to the library team, which will review and decide on the PR/issue. 
  
    T-rustdoc
  Relevant to the rustdoc team, which will review and decide on the PR/issue. 
  
    T-rustdoc-frontend
  Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. 
  
    WG-trait-system-refactor
  The Rustc Trait System Refactor Initiative (-Znext-solver) 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Successful merges:
rls#126856 (remove deprecated toolrls)widthandprecisionto 16 bits #136932 (Reduce formattingwidthandprecisionto 16 bits)-Wlinker-messageswrappers fromrust-lldrmake test #138052 (strip-Wlinker-messageswrappers fromrust-lldrmake test)-Zunpretty=hirfor parsed attrs #138063 (Improve-Zunpretty=hirfor parsed attrs)ci_rustc_if_unchanged_logictest for local environments #138245 (stabilizeci_rustc_if_unchanged_logictest for local environments)AdtFlags::IS_ANONYMOUSandCopy/Clonecondition for anonymous ADT #138296 (RemoveAdtFlags::IS_ANONYMOUSandCopy/Clonecondition for anonymous ADT)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup