Keep space if arg does not follow punctuation when lint unused parens

[mu001999]

Fixes #138234

If the arg follows punctuation, still pass left_pos with None and no space will be added, else then pass left_pos with Some(arg.span.lo()), so that we can add the space as expected.

And emit_unused_delims can make sure no more space will be added if the expr follows space.

[rustbot]

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[mu001999]

r? compiler

[compiler-errors]

Computing source information can be very expensive, since this operates on the "good path".

@bors try @rust-timer queue

[bors]

⌛ Trying commit 42ce300 with merge 3bb53a8...

[bors]

☀️ Try build successful - checks-actions
Build commit: 3bb53a8 (3bb53a8f01333496b0195c53a7ae030a1aae2ec4)

[rust-timer]

Finished benchmarking commit (3bb53a8): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	4.9%	[0.2%, 117.0%]	186
Regressions ❌ (secondary)	11.0%	[0.2%, 75.0%]	50
Improvements ✅ (primary)	-0.6%	[-1.3%, -0.3%]	3
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	4.8%	[-1.3%, 117.0%]	189

Max RSS (memory usage)

Results (primary 1.4%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	1.3%	[0.7%, 1.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	1.4%	[1.4%, 1.4%]	1

Cycles

Results (primary 19.9%, secondary 65.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	20.3%	[0.8%, 187.7%]	57
Regressions ❌ (secondary)	65.0%	[1.7%, 154.5%]	15
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	19.9%	[-0.9%, 187.7%]	58

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.776s -> 779.66s (0.50%)
Artifact size: 365.58 MiB -> 365.48 MiB (-0.03%)

[mu001999]

oops...

[compiler-errors]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.