Skip to content

Rollup of 8 pull requests #138185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
917d2eb
add verbatim linker to AIXLinker
Feb 20, 2025
1a5a453
atomic: clarify that failing conditional RMW operations are not 'writes'
RalfJung Mar 4, 2025
e0b7577
linux x64: default to `-znostart-stop-gc`
lqd Feb 26, 2025
9d8ce72
compiler: factor Windows x86-32 ABI impl into its own file
workingjubilee Feb 21, 2025
4e4bed8
setTargetTriple now accepts Triple rather than string
ZequanWu Mar 7, 2025
8814679
rename Triple to Target
ZequanWu Mar 7, 2025
bbc80a8
Delay bug for negative auto trait rather than ICEing
compiler-errors Mar 7, 2025
bae4682
Rename print_something to should_render
compiler-errors Mar 5, 2025
9ae9453
Fix pretty printing of parsed attrs in hir_pretty
compiler-errors Mar 5, 2025
fb04372
Move all alloc integration tests to a new alloctests crate
bjorn3 Feb 6, 2025
be1e0b7
Move most Rc tests to alloctests
bjorn3 Feb 6, 2025
701bedc
Move last remaining Rc test to alloctests
bjorn3 Feb 6, 2025
ae5687e
Fully test the alloc crate through alloctests
bjorn3 Feb 6, 2025
22d0440
Add comments
bjorn3 Feb 13, 2025
1d586b5
Rollup merge of #136642 - bjorn3:separate_alloctest_crate, r=cuviper
compiler-errors Mar 7, 2025
0270489
Rollup merge of #137337 - dalvescb:master, r=petrochenkov
compiler-errors Mar 7, 2025
f47df77
Rollup merge of #137363 - workingjubilee:untangle-x86-abi-impl, r=jie…
compiler-errors Mar 7, 2025
ae1699f
Rollup merge of #137685 - lqd:nostart-stop-gc, r=petrochenkov
compiler-errors Mar 7, 2025
541029d
Rollup merge of #138000 - RalfJung:atomic-rmw, r=Amanieu
compiler-errors Mar 7, 2025
dee3c9c
Rollup merge of #138063 - compiler-errors:improve-attr-unpretty, r=jd…
compiler-errors Mar 7, 2025
3dafc37
Rollup merge of #138137 - ZequanWu:fix-triple, r=cuviper
compiler-errors Mar 7, 2025
92e7038
Rollup merge of #138173 - compiler-errors:incoherent-negative-impl, r…
compiler-errors Mar 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move last remaining Rc test to alloctests
  • Loading branch information
bjorn3 committed Mar 7, 2025
commit 701bedc323b0314ef6f084ba98ed18327faa36bc
3 changes: 0 additions & 3 deletions library/alloc/src/rc/mod.rs → library/alloc/src/rc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,6 @@ use crate::string::String;
#[cfg(not(no_global_oom_handling))]
use crate::vec::Vec;

#[cfg(test)]
mod tests;

// This is repr(C) to future-proof against possible field-reordering, which
// would interfere with otherwise safe [into|from]_raw() of transmutable
// inner types.
Expand Down
15 changes: 0 additions & 15 deletions library/alloc/src/rc/tests.rs

This file was deleted.

18 changes: 18 additions & 0 deletions library/alloctests/tests/rc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,24 @@ fn weak_self_cyclic() {
// hopefully we don't double-free (or leak)...
}

#[test]
fn is_unique() {
fn is_unique<T>(this: &Rc<T>) -> bool {
Rc::weak_count(this) == 0 && Rc::strong_count(this) == 1
}

let x = Rc::new(3);
assert!(is_unique(&x));
let y = x.clone();
assert!(!is_unique(&x));
drop(y);
assert!(is_unique(&x));
let w = Rc::downgrade(&x);
assert!(!is_unique(&x));
drop(w);
assert!(is_unique(&x));
}

#[test]
fn test_strong_count() {
let a = Rc::new(0);
Expand Down