Avoid collecting associated types for undefined trait #137631

TaKO8Ki · 2025-02-25T19:20:55Z

rustbot · 2025-02-25T19:20:59Z

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-02-25T19:21:01Z

HIR ty lowering was modified

cc @fmease

compiler-errors · 2025-02-25T19:24:58Z

tests/ui/associated-types/ice-issue-137508.rs

+}
+
+fn main() {
+    let _: dyn Tr + ?Foo();


This doesn't have to do with parenthesized syntax. This also ICEs: + ?Foo<Assoc = ()>.

Please edit the test name so it's more clear what it's testing, add the issue number as a comment like:

// Fix for <https://github.com/issues....>

Sorry, I forgot to mention explicitly:

Change the test to use + ?Foo<Assoc = ()> rather than the parentheses syntax.

Ok. Thanks.

compiler-errors · 2025-02-25T19:25:15Z

compiler/rustc_hir_analysis/src/hir_ty_lowering/errors.rs

-                        trait_def,
-                    );
+                    let trait_def = path.res.opt_def_id();
+                    let assoc_item = trait_def.and_then(|trait_def_id| {


Please leave a comment here saying that we don't want to unwrap a trait def id if it resolves incorrectly.

compiler-errors · 2025-02-25T19:41:47Z

Actually, #137554 is the same issue, but with a different kind of item.

Instead of calling opt_def_id, please match on the Res::Def(DefKind::Trait, def_id). This will avoid ICEing in case the path resolves, but it resolves to the wrong kind of item. Then you can add a regression test for this too.

compiler-errors

Add a test for #137554, and squash this into one commit.

Also no need to click the "request review" button; I'll review the PR when I have free time. All it does is give me an unnecessary notification.

compiler-errors · 2025-02-25T19:59:58Z

tests/ui/associated-types/avoid-getting-associated-items-of-undefined-trait.rs

+    let _: dyn Tr + ?Foo<Assoc = ()>;
+    //~^ ERROR: `?Trait` is not permitted in trait object types
+    //~| ERROR: cannot find trait `Foo` in this scope
+    //~| ERROR: the value of the associated type `Item` in `Tr` must be specifi


Suggested change

//~| ERROR: the value of the associated type `Item` in `Tr` must be specifi

//~| ERROR: the value of the associated type `Item` in `Tr` must be specified

rename ui tests check if res is trait def fix typo regression test for rust-lang#137554

compiler-errors · 2025-02-25T20:27:52Z

@bors r+ rollup

bors · 2025-02-25T20:27:55Z

📌 Commit b7a5497 has been approved by compiler-errors

It is now in the queue for this repository.

…rrors Avoid collecting associated types for undefined trait Fixes rust-lang#137508 Fixes rust-lang#137554

Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#136457 (Expose algebraic floating point intrinsics) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) - rust-lang#137671 (Make -Z unpretty=mir suggest -Z dump-mir as well for discoverability) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137631 - TaKO8Ki:issue-137508, r=compiler-errors Avoid collecting associated types for undefined trait Fixes rust-lang#137508 Fixes rust-lang#137554

rustbot assigned compiler-errors Feb 25, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2025

TaKO8Ki force-pushed the issue-137508 branch from 45e148a to 1ac2051 Compare February 25, 2025 19:21

compiler-errors requested changes Feb 25, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2025

This comment has been minimized.

Sign in to view

TaKO8Ki requested a review from compiler-errors February 25, 2025 19:59

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2025

TaKO8Ki removed the request for review from compiler-errors February 25, 2025 20:00

compiler-errors requested changes Feb 25, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2025

fix rust-lang#137508

b7a5497

rename ui tests check if res is trait def fix typo regression test for rust-lang#137554

TaKO8Ki force-pushed the issue-137508 branch from 4a77dae to b7a5497 Compare February 25, 2025 20:11

compiler-errors approved these changes Feb 25, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2025

fmease added a commit to fmease/rust that referenced this pull request Feb 26, 2025

Rollup merge of rust-lang#137631 - TaKO8Ki:issue-137508, r=compiler-e…

1507108

…rrors Avoid collecting associated types for undefined trait Fixes rust-lang#137508 Fixes rust-lang#137554

fmease mentioned this pull request Feb 26, 2025

Rollup of 10 pull requests #137672

Closed

fmease mentioned this pull request Feb 26, 2025

Rollup of 10 pull requests #137688

Merged

bors merged commit 2fc8823 into rust-lang:master Feb 26, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Feb 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid collecting associated types for undefined trait #137631

Avoid collecting associated types for undefined trait #137631

TaKO8Ki commented Feb 25, 2025 •

edited

Loading

rustbot commented Feb 25, 2025

rustbot commented Feb 25, 2025

compiler-errors Feb 25, 2025

compiler-errors Feb 25, 2025

TaKO8Ki Feb 25, 2025

compiler-errors Feb 25, 2025

compiler-errors commented Feb 25, 2025 •

edited

Loading

This comment has been minimized.

compiler-errors left a comment

compiler-errors Feb 25, 2025

compiler-errors commented Feb 25, 2025

bors commented Feb 25, 2025

	//~\| ERROR: the value of the associated type `Item` in `Tr` must be specifi
	//~\| ERROR: the value of the associated type `Item` in `Tr` must be specified

Avoid collecting associated types for undefined trait #137631

Avoid collecting associated types for undefined trait #137631

Conversation

TaKO8Ki commented Feb 25, 2025 • edited Loading

rustbot commented Feb 25, 2025

rustbot commented Feb 25, 2025

compiler-errors Feb 25, 2025

Choose a reason for hiding this comment

compiler-errors Feb 25, 2025

Choose a reason for hiding this comment

TaKO8Ki Feb 25, 2025

Choose a reason for hiding this comment

compiler-errors Feb 25, 2025

Choose a reason for hiding this comment

compiler-errors commented Feb 25, 2025 • edited Loading

This comment has been minimized.

compiler-errors left a comment

Choose a reason for hiding this comment

compiler-errors Feb 25, 2025

Choose a reason for hiding this comment

compiler-errors commented Feb 25, 2025

bors commented Feb 25, 2025

TaKO8Ki commented Feb 25, 2025 •

edited

Loading

compiler-errors commented Feb 25, 2025 •

edited

Loading