Skip to content

[DO NOT MERGE] test safe x86 intrinsics #137033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] test safe x86 intrinsics #137033

wants to merge 1 commit into from

Conversation

@usamoi
Copy link
Contributor

@usamoi usamoi commented Feb 14, 2025

This draft pull request is only used for a crater run, to check for any breakage caused by rust-lang/stdarch#1714 in the ecosystem.

cc @Amanieu

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu
jieyouxu reviewed Feb 14, 2025
View reviewed changes
.gitmodules
Comment on lines 21 to 24
[submodule "library/stdarch"]
path = library/stdarch
url = https://github.com/rust-lang/stdarch.git
url = https://github.com/usamoi/stdarch.git
shallow = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, you may need to additionally specify your branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data in .gitmodules doesn't matter, what you need to do is cd library/stdarch and check out your branch in that directory.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Feb 14, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@usamoi usamoi force-pushed the test-safe-x86-intrinsics branch 2 times, most recently from 0d8f468 to 8fe9640 Compare February 14, 2025 17:12
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@usamoi usamoi force-pushed the test-safe-x86-intrinsics branch from 8fe9640 to 3303afc Compare February 14, 2025 17:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@usamoi usamoi force-pushed the test-safe-x86-intrinsics branch from 3303afc to 3c29d64 Compare February 14, 2025 17:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@usamoi usamoi force-pushed the test-safe-x86-intrinsics branch from 3c29d64 to 3be00d0 Compare February 14, 2025 18:58
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@usamoi usamoi force-pushed the test-safe-x86-intrinsics branch from 3be00d0 to 6ba649a Compare February 14, 2025 19:29
@Amanieu
Copy link
Member

Amanieu commented Feb 14, 2025

@bors try

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

⌛ Trying commit 6ba649a with merge ef5216c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
@bors
Auto merge of rust-lang#137033 - usamoi:test-safe-x86-intrinsics, r=<…
ef5216c 
…try>

[DO NOT MERGE] test safe x86 intrinsics

This draft pull request is only used for a crater run, to check for any breakage caused by rust-lang/stdarch#1714 in the ecosystem.

cc `@Amanieu`
@bors
Copy link
Collaborator

bors commented Feb 14, 2025

☀️ Try build successful - checks-actions
Build commit: ef5216c (ef5216c337126ffe24d074826f4023948c4a9b8e)

@Amanieu
Copy link
Member

Amanieu commented Feb 14, 2025

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-137033 created and queued.
🤖 Automatically detected try build ef5216c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-137033 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 14, 2025
@craterbot
Copy link
Collaborator

🎉 Experiment pr-137033 is completed!
📊 5 regressed and 4 fixed (583035 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 15, 2025
@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2025

It seems there were no regressions, so this should be fine to land.

@usamoi usamoi closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amanieu Amanieu Amanieu left review comments

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@Noratrieb Noratrieb

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@usamoi @rustbot @rust-log-analyzer @Amanieu @bors @craterbot @jieyouxu @Noratrieb