Skip to content

Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering - #136630

Merged
bors merged 2 commits into
rust-lang:masterfrom
jieyouxu:render_tests
Feb 6, 2025
Merged

Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering#136630
bors merged 2 commits into
rust-lang:masterfrom
jieyouxu:render_tests

Conversation

@jieyouxu

@jieyouxu jieyouxu commented Feb 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I don't really know how to test if this unbreaks CI (since #136607 reported that this breaks the CI test rendering sometimes).

Fixes #136607.

r? @ChrisDenton (two Windows process tests, but feel free to reroll)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 6, 2025
@ChrisDenton

ChrisDenton commented Feb 6, 2025

Copy link
Copy Markdown
Member

Spawning cmd is just for lack of a placeholder executable that will stay open until we want them to exit. I think ultimately these should perhaps become ui or even run-make tests (if absolutely necessary).

Still, I don't want the perfect to be the enemy of better so r=me on this.

@jieyouxu

jieyouxu commented Feb 6, 2025

Copy link
Copy Markdown
Member Author

@bors r=@ChrisDenton rollup

@bors

bors commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 9c5f025 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 6, 2025
Merged
ranger-ross
ranger-ross reviewed Feb 6, 2025
View reviewed changes
Comment thread src/bootstrap/src/utils/render_tests.rs
Comment on lines +313 to +315
self.benches = vec![];
self.failures = vec![];
self.ignored_tests = 0;

@ranger-ross ranger-ross Feb 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I over looked this in #135355 😅

@bors
bors merged commit 5b22425 into rust-lang:master Feb 6, 2025
@rustbot rustbot added this to the 1.86.0 milestone Feb 6, 2025
@jieyouxu
jieyouxu deleted the render_tests branch February 6, 2025 20:15
@ChrisDenton ChrisDenton mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranger-ross ranger-ross ranger-ross left review comments

Assignees

@ChrisDenton ChrisDenton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

Panic (attempt to subtract with overflow) when calculating the number of passed_tests in utils\render_tests.rs

5 participants

@jieyouxu @ChrisDenton @bors @ranger-ross @rustbot