stabilize stage management for rustc tools, especially on cargo
#135990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #135832) made this pull request unmergeable. Please resolve the merge conflicts. |
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
d067acb to
4ddb1ac
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
5fc8108 to
79b6c4b
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
460b835 to
6ea392a
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
6ea392a to
e627ca5
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
e627ca5 to
01fcb0d
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
01fcb0d to
a992247
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
a992247 to
abb8c0f
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
abb8c0f to
e138f5a
Compare
This comment has been minimized.
This comment has been minimized.
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
e138f5a to
b222ef8
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #136747) made this pull request unmergeable. Please resolve the merge conflicts. |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
fb0ea00 to
cb5df50
Compare
onur-ozkan
force-pushed
the
stabilize-stage-handling
branch
from
cb5df50 to
186cb6f
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☔ The latest upstream changes (presumably #137176) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2025
…r=jieyouxu,Kobzol stabilize stage management for rustc tools rust-lang#135990 got out of control due to excessive complexity. This PR aims to achieve the same goal with a simpler approach, likely through multiple smaller PRs. I will keep the other one read-only and open as a reference for future work. This work stabilizes the staging logic for `ToolRustc` programs, so you no longer need to handle build and target compilers separately in steps. Previously, most tools didn't do this correctly, which was causing the compiler to be built twice (e.g., `x test cargo --stage 1` would compile the stage 2 compiler before, but now it only compiles the stage 1 compiler). I also tried to document how we should write `ToolRustc` steps as they are quite different and require more attention than other tools. Next goal is to stabilize how stages are handled for the rustc itself. Currently, `x build --stage 1` builds the stage 1 compiler which is fine, but `x build compiler --stage 1` builds stage 2 compiler. ~~for now, r? ghost~~
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Feb 24, 2025
…u,Kobzol stabilize stage management for rustc tools rust-lang/rust#135990 got out of control due to excessive complexity. This PR aims to achieve the same goal with a simpler approach, likely through multiple smaller PRs. I will keep the other one read-only and open as a reference for future work. This work stabilizes the staging logic for `ToolRustc` programs, so you no longer need to handle build and target compilers separately in steps. Previously, most tools didn't do this correctly, which was causing the compiler to be built twice (e.g., `x test cargo --stage 1` would compile the stage 2 compiler before, but now it only compiles the stage 1 compiler). I also tried to document how we should write `ToolRustc` steps as they are quite different and require more attention than other tools. Next goal is to stabilize how stages are handled for the rustc itself. Currently, `x build --stage 1` builds the stage 1 compiler which is fine, but `x build compiler --stage 1` builds stage 2 compiler. ~~for now, r? ghost~~
github-merge-queue bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Feb 24, 2025
…u,Kobzol stabilize stage management for rustc tools rust-lang/rust#135990 got out of control due to excessive complexity. This PR aims to achieve the same goal with a simpler approach, likely through multiple smaller PRs. I will keep the other one read-only and open as a reference for future work. This work stabilizes the staging logic for `ToolRustc` programs, so you no longer need to handle build and target compilers separately in steps. Previously, most tools didn't do this correctly, which was causing the compiler to be built twice (e.g., `x test cargo --stage 1` would compile the stage 2 compiler before, but now it only compiles the stage 1 compiler). I also tried to document how we should write `ToolRustc` steps as they are quite different and require more attention than other tools. Next goal is to stabilize how stages are handled for the rustc itself. Currently, `x build --stage 1` builds the stage 1 compiler which is fine, but `x build compiler --stage 1` builds stage 2 compiler. ~~for now, r? ghost~~
BoxyUwU
pushed a commit
to BoxyUwU/rustc-dev-guide
that referenced
this pull request
Feb 25, 2025
…u,Kobzol stabilize stage management for rustc tools rust-lang/rust#135990 got out of control due to excessive complexity. This PR aims to achieve the same goal with a simpler approach, likely through multiple smaller PRs. I will keep the other one read-only and open as a reference for future work. This work stabilizes the staging logic for `ToolRustc` programs, so you no longer need to handle build and target compilers separately in steps. Previously, most tools didn't do this correctly, which was causing the compiler to be built twice (e.g., `x test cargo --stage 1` would compile the stage 2 compiler before, but now it only compiles the stage 1 compiler). I also tried to document how we should write `ToolRustc` steps as they are quite different and require more attention than other tools. Next goal is to stabilize how stages are handled for the rustc itself. Currently, `x build --stage 1` builds the stage 1 compiler which is fine, but `x build compiler --stage 1` builds stage 2 compiler. ~~for now, r? ghost~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-to be filled-
r? ghost