Skip to content

Update emscripten std tests #135948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 4 commits into from
Jan 26, 2025
Merged

Update emscripten std tests #135948

bors merged 4 commits into from
Jan 26, 2025

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 23, 2025 •
edited
Loading

This disables a bunch of emscripten tests that test things emscripten doesn't support and re-enables a whole bunch of tests which now work just fine on emscripten.

Tested with EMCC_CFLAGS="-s MAXIMUM_MEMORY=2GB" ./x.py test library/ --target wasm32-unknown-emscripten.

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ labels Jan 23, 2025
@rustbot

This comment was marked as outdated.

Sign in to view
@bjorn3
Copy link
Member Author

bjorn3 commented Jan 23, 2025

Tested with EMCC_CFLAGS="-s MAXIMUM_MEMORY=2GB" ./x.py test library/ --target wasm32-unknown-emscripten.

Maybe the target documentation should be updated to mention that this is necessary?

@jieyouxu
Copy link
Member

jieyouxu commented Jan 24, 2025

It should, yes

bjorn3 added 4 commits January 24, 2025 09:25
@bjorn3
Fix testing of the standard library with Emscripten
d0a70d9 
This does need EMCC_CFLAGS="-s MAXIMUM_MEMORY=2GB" avoid several OOMs.
@bjorn3
Remove a bunch of emscripten test ignores
88ff147 
They are either outdated as emscripten now supports i128 or they are
subsumed by #[cfg_attr(not(panic = "unwind"), ignore]
@bjorn3
Update a bunch of comments from before wasi support was added
a20996c
@bjorn3
Update target docs to mention MAXIMUM_MEMORY=2GB
6b18473
@bjorn3 bjorn3 force-pushed the update_emscripten_std_tests branch from c69e084 to 6b18473 Compare January 24, 2025 09:39
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@jieyouxu
Copy link
Member

jieyouxu commented Jan 24, 2025

r? libs

@rustbot rustbot assigned Mark-Simulacrum and unassigned fmease Jan 24, 2025
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 25, 2025

@bors r+

Seems OK.

@bors
Copy link
Collaborator

bors commented Jan 25, 2025

📌 Commit 6b18473 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2025
@jhpratt jhpratt mentioned this pull request Jan 26, 2025
Merged
@bors bors merged commit b58221e into rust-lang:master Jan 26, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 26, 2025
@bjorn3 bjorn3 deleted the update_emscripten_std_tests branch January 26, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

6 participants

@bjorn3 @rustbot @jieyouxu @Mark-Simulacrum @bors @fmease